Diff
Modified: trunk/Source/WebCore/ChangeLog (183855 => 183856)
--- trunk/Source/WebCore/ChangeLog 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/ChangeLog 2015-05-06 06:17:02 UTC (rev 183856)
@@ -1,5 +1,34 @@
2015-05-05 Žan Doberšek <[email protected]>
+ Add missing vtable override specifiers under Source/WebCore/Modules
+ https://bugs.webkit.org/show_bug.cgi?id=144569
+
+ Reviewed by Darin Adler.
+
+ Update virtual method overrides under Source/WebCore/Modules
+ which are missing the override specifier.
+
+ * Modules/mediasource/SourceBuffer.h:
+ * Modules/mediastream/MediaStreamTrack.h:
+ * Modules/mediastream/RTCVoidRequestImpl.h:
+ * Modules/webaudio/AudioContext.h:
+ (WebCore::AudioContext::mediaType): Deleted.
+ (WebCore::AudioContext::presentationType): Deleted.
+ (WebCore::AudioContext::canReceiveRemoteControlCommands): Deleted.
+ (WebCore::AudioContext::didReceiveRemoteControlCommand): Deleted.
+ (WebCore::AudioContext::overrideBackgroundPlaybackRestriction): Deleted.
+ * Modules/webaudio/MediaStreamAudioDestinationNode.h:
+ * Modules/webaudio/MediaStreamAudioSourceNode.h:
+ * Modules/webaudio/WaveShaperDSPKernel.h:
+ * Modules/websockets/WebSocketChannel.h:
+ (WebCore::WebSocketChannel::refThreadableWebSocketChannel): Deleted.
+ (WebCore::WebSocketChannel::derefThreadableWebSocketChannel): Deleted.
+ * Modules/websockets/WorkerThreadableWebSocketChannel.h:
+ (WebCore::WorkerThreadableWebSocketChannel::refThreadableWebSocketChannel): Deleted.
+ (WebCore::WorkerThreadableWebSocketChannel::derefThreadableWebSocketChannel): Deleted.
+
+2015-05-05 Žan Doberšek <[email protected]>
+
EventHandler::m_eventHandlerWillResetCapturingMouseEventsElement is incorrectly initialized
https://bugs.webkit.org/show_bug.cgi?id=144583
Modified: trunk/Source/WebCore/Modules/mediasource/SourceBuffer.h (183855 => 183856)
--- trunk/Source/WebCore/Modules/mediasource/SourceBuffer.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBuffer.h 2015-05-06 06:17:02 UTC (rev 183856)
@@ -148,7 +148,7 @@
virtual bool sourceBufferPrivateHasAudio(const SourceBufferPrivate*) const override;
virtual bool sourceBufferPrivateHasVideo(const SourceBufferPrivate*) const override;
virtual void sourceBufferPrivateDidBecomeReadyForMoreSamples(SourceBufferPrivate*, AtomicString trackID) override;
- virtual MediaTime sourceBufferPrivateFastSeekTimeForMediaTime(SourceBufferPrivate*, const MediaTime&, const MediaTime& negativeThreshold, const MediaTime& positiveThreshold);
+ virtual MediaTime sourceBufferPrivateFastSeekTimeForMediaTime(SourceBufferPrivate*, const MediaTime&, const MediaTime& negativeThreshold, const MediaTime& positiveThreshold) override;
virtual void sourceBufferPrivateAppendComplete(SourceBufferPrivate*, AppendResult) override;
virtual void sourceBufferPrivateDidReceiveRenderingError(SourceBufferPrivate*, int errorCode) override;
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h (183855 => 183856)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h 2015-05-06 06:17:02 UTC (rev 183856)
@@ -121,9 +121,9 @@
virtual void derefEventTarget() override final { deref(); }
// MediaStreamTrackPrivateClient
- void trackReadyStateChanged();
- void trackMutedChanged();
- void trackEnabledChanged();
+ void trackReadyStateChanged() override;
+ void trackMutedChanged() override;
+ void trackEnabledChanged() override;
Vector<RefPtr<Event>> m_scheduledEvents;
Modified: trunk/Source/WebCore/Modules/mediastream/RTCVoidRequestImpl.h (183855 => 183856)
--- trunk/Source/WebCore/Modules/mediastream/RTCVoidRequestImpl.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/mediastream/RTCVoidRequestImpl.h 2015-05-06 06:17:02 UTC (rev 183856)
@@ -47,8 +47,8 @@
static PassRefPtr<RTCVoidRequestImpl> create(ScriptExecutionContext*, PassRefPtr<VoidCallback>, PassRefPtr<RTCPeerConnectionErrorCallback>);
virtual ~RTCVoidRequestImpl();
- virtual void requestSucceeded();
- virtual void requestFailed(const String& error);
+ virtual void requestSucceeded() override;
+ virtual void requestFailed(const String& error) override;
private:
RTCVoidRequestImpl(ScriptExecutionContext*, PassRefPtr<VoidCallback>, PassRefPtr<RTCPeerConnectionErrorCallback>);
Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.h (183855 => 183856)
--- trunk/Source/WebCore/Modules/webaudio/AudioContext.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.h 2015-05-06 06:17:02 UTC (rev 183856)
@@ -307,13 +307,13 @@
void derefUnfinishedSourceNodes();
// MediaSessionClient
- virtual MediaSession::MediaType mediaType() const { return MediaSession::WebAudio; }
- virtual MediaSession::MediaType presentationType() const { return MediaSession::WebAudio; }
- virtual bool canReceiveRemoteControlCommands() const { return false; }
- virtual void didReceiveRemoteControlCommand(MediaSession::RemoteControlCommandType) { }
- virtual bool overrideBackgroundPlaybackRestriction() const { return false; }
+ virtual MediaSession::MediaType mediaType() const override { return MediaSession::WebAudio; }
+ virtual MediaSession::MediaType presentationType() const override { return MediaSession::WebAudio; }
+ virtual void mayResumePlayback(bool shouldResume) override;
virtual void suspendPlayback() override;
- virtual void mayResumePlayback(bool shouldResume) override;
+ virtual bool canReceiveRemoteControlCommands() const override { return false; }
+ virtual void didReceiveRemoteControlCommand(MediaSession::RemoteControlCommandType) override { }
+ virtual bool overrideBackgroundPlaybackRestriction() const override { return false; }
// EventTarget
virtual void refEventTarget() override { ref(); }
Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h (183855 => 183856)
--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h 2015-05-06 06:17:02 UTC (rev 183856)
@@ -46,8 +46,8 @@
MediaStream* stream() { return m_stream.get(); }
// AudioNode.
- virtual void process(size_t framesToProcess);
- virtual void reset();
+ virtual void process(size_t framesToProcess) override;
+ virtual void reset() override;
RealtimeMediaSource* mediaStreamSource();
Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.h (183855 => 183856)
--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.h 2015-05-06 06:17:02 UTC (rev 183856)
@@ -47,11 +47,11 @@
MediaStream* mediaStream() { return m_mediaStream.get(); }
// AudioNode
- virtual void process(size_t framesToProcess);
- virtual void reset();
+ virtual void process(size_t framesToProcess) override;
+ virtual void reset() override;
// AudioSourceProviderClient
- virtual void setFormat(size_t numberOfChannels, float sampleRate);
+ virtual void setFormat(size_t numberOfChannels, float sampleRate) override;
AudioSourceProvider* audioSourceProvider() const { return m_audioSourceProvider; }
Modified: trunk/Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.h (183855 => 183856)
--- trunk/Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.h 2015-05-06 06:17:02 UTC (rev 183856)
@@ -43,8 +43,8 @@
explicit WaveShaperDSPKernel(WaveShaperProcessor*);
// AudioDSPKernel
- virtual void process(const float* source, float* dest, size_t framesToProcess);
- virtual void reset();
+ virtual void process(const float* source, float* dest, size_t framesToProcess) override;
+ virtual void reset() override;
virtual double tailTime() const override { return 0; }
virtual double latencyTime() const override;
Modified: trunk/Source/WebCore/Modules/websockets/WebSocketChannel.h (183855 => 183856)
--- trunk/Source/WebCore/Modules/websockets/WebSocketChannel.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/websockets/WebSocketChannel.h 2015-05-06 06:17:02 UTC (rev 183856)
@@ -109,17 +109,17 @@
};
// FileReaderLoaderClient functions.
- virtual void didStartLoading();
- virtual void didReceiveData();
- virtual void didFinishLoading();
- virtual void didFail(int errorCode);
+ virtual void didStartLoading() override;
+ virtual void didReceiveData() override;
+ virtual void didFinishLoading() override;
+ virtual void didFail(int errorCode) override;
using RefCounted<WebSocketChannel>::ref;
using RefCounted<WebSocketChannel>::deref;
protected:
- virtual void refThreadableWebSocketChannel() { ref(); }
- virtual void derefThreadableWebSocketChannel() { deref(); }
+ virtual void refThreadableWebSocketChannel() override { ref(); }
+ virtual void derefThreadableWebSocketChannel() override { deref(); }
private:
WebSocketChannel(Document*, WebSocketChannelClient*);
Modified: trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h (183855 => 183856)
--- trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h 2015-05-06 06:17:02 UTC (rev 183856)
@@ -119,8 +119,8 @@
using RefCounted<WorkerThreadableWebSocketChannel>::deref;
protected:
- virtual void refThreadableWebSocketChannel() { ref(); }
- virtual void derefThreadableWebSocketChannel() { deref(); }
+ virtual void refThreadableWebSocketChannel() override { ref(); }
+ virtual void derefThreadableWebSocketChannel() override { deref(); }
private:
// Bridge for Peer. Running on the worker thread.
