Diff
Modified: trunk/Source/WebCore/ChangeLog (183856 => 183857)
--- trunk/Source/WebCore/ChangeLog 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/ChangeLog 2015-05-06 06:21:20 UTC (rev 183857)
@@ -1,5 +1,27 @@
2015-05-05 Žan Doberšek <[email protected]>
+ Add missing vtable override specifiers under Source/WebCore/rendering
+ https://bugs.webkit.org/show_bug.cgi?id=144570
+
+ Reviewed by Darin Adler.
+
+ Update virtual method overrides under Source/WebCore/rendering
+ which are missing the override specifiers.
+
+ * rendering/InlineTextBox.h:
+ (WebCore::InlineTextBox::calculateBoundaries): Deleted.
+ * rendering/RenderFlowThread.h:
+ * rendering/RenderMedia.h:
+ (WebCore::RenderMedia::shadowControlsNeedCustomLayoutMetrics): Deleted.
+ * rendering/RenderMultiColumnSet.h:
+ * rendering/RenderRegion.h:
+ * rendering/RenderRegionSet.h:
+ * rendering/RenderThemeGtk.h:
+ * rendering/mathml/RenderMathMLOperator.h:
+ * rendering/svg/RenderSVGBlock.h:
+
+2015-05-05 Žan Doberšek <[email protected]>
+
Add missing vtable override specifiers under Source/WebCore/Modules
https://bugs.webkit.org/show_bug.cgi?id=144569
Modified: trunk/Source/WebCore/rendering/InlineTextBox.h (183856 => 183857)
--- trunk/Source/WebCore/rendering/InlineTextBox.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/InlineTextBox.h 2015-05-06 06:21:20 UTC (rev 183857)
@@ -114,14 +114,14 @@
TextRun constructTextRun(const RenderStyle&, const FontCascade&, String, unsigned maximumLength, String* hyphenatedStringBuffer = nullptr) const;
public:
- virtual FloatRect calculateBoundaries() const { return FloatRect(x(), y(), width(), height()); }
+ virtual FloatRect calculateBoundaries() const override { return FloatRect(x(), y(), width(), height()); }
virtual LayoutRect localSelectionRect(int startPos, int endPos) const;
bool isSelected(int startPos, int endPos) const;
void selectionStartEnd(int& sPos, int& ePos);
protected:
- virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom);
+ virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom) override;
virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom, HitTestAction) override;
private:
Modified: trunk/Source/WebCore/rendering/RenderFlowThread.h (183856 => 183857)
--- trunk/Source/WebCore/rendering/RenderFlowThread.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.h 2015-05-06 06:21:20 UTC (rev 183857)
@@ -244,7 +244,7 @@
virtual RenderFlowThread* locateFlowThreadContainingBlock() const override { return const_cast<RenderFlowThread*>(this); }
- virtual const char* renderName() const = 0;
+ virtual const char* renderName() const override = 0;
// Overridden by columns/pages to set up an initial logical width of the page width even when
// no regions have been generated yet.
Modified: trunk/Source/WebCore/rendering/RenderMedia.h (183856 => 183857)
--- trunk/Source/WebCore/rendering/RenderMedia.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/RenderMedia.h 2015-05-06 06:21:20 UTC (rev 183857)
@@ -53,7 +53,7 @@
virtual bool requiresForcedStyleRecalcPropagation() const override final { return true; }
- virtual bool shadowControlsNeedCustomLayoutMetrics() const { return true; }
+ virtual bool shadowControlsNeedCustomLayoutMetrics() const override { return true; }
};
} // namespace WebCore
Modified: trunk/Source/WebCore/rendering/RenderMultiColumnSet.h (183856 => 183857)
--- trunk/Source/WebCore/rendering/RenderMultiColumnSet.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/RenderMultiColumnSet.h 2015-05-06 06:21:20 UTC (rev 183857)
@@ -117,7 +117,7 @@
LayoutPoint columnTranslationForOffset(const LayoutUnit&) const;
- void paintColumnRules(PaintInfo&, const LayoutPoint& paintOffset);
+ void paintColumnRules(PaintInfo&, const LayoutPoint& paintOffset) override;
enum ColumnHitTestTranslationMode {
ClampHitTestTranslationToColumns,
Modified: trunk/Source/WebCore/rendering/RenderRegion.h (183856 => 183857)
--- trunk/Source/WebCore/rendering/RenderRegion.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/RenderRegion.h 2015-05-06 06:21:20 UTC (rev 183857)
@@ -46,7 +46,7 @@
class RenderRegion : public RenderBlockFlow {
public:
- virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
+ virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
void setFlowThreadPortionRect(const LayoutRect& rect) { m_flowThreadPortionRect = rect; }
LayoutRect flowThreadPortionRect() const { return m_flowThreadPortionRect; }
Modified: trunk/Source/WebCore/rendering/RenderRegionSet.h (183856 => 183857)
--- trunk/Source/WebCore/rendering/RenderRegionSet.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/RenderRegionSet.h 2015-05-06 06:21:20 UTC (rev 183857)
@@ -55,7 +55,7 @@
private:
virtual void installFlowThread() override final;
- virtual const char* renderName() const = 0;
+ virtual const char* renderName() const override = 0;
virtual bool isRenderRegionSet() const override final { return true; }
};
Modified: trunk/Source/WebCore/rendering/RenderThemeGtk.h (183856 => 183857)
--- trunk/Source/WebCore/rendering/RenderThemeGtk.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/RenderThemeGtk.h 2015-05-06 06:21:20 UTC (rev 183857)
@@ -139,7 +139,7 @@
virtual bool paintSearchField(const RenderObject&, const PaintInfo&, const IntRect&) override;
virtual void adjustSearchFieldResultsButtonStyle(StyleResolver&, RenderStyle&, Element*) const override;
- virtual bool paintSearchFieldResultsButton(const RenderObject&, const PaintInfo&, const IntRect&);
+ virtual bool paintSearchFieldResultsButton(const RenderObject&, const PaintInfo&, const IntRect&) override;
virtual void adjustSearchFieldCancelButtonStyle(StyleResolver&, RenderStyle&, Element*) const override;
virtual bool paintSearchFieldCancelButton(const RenderObject&, const PaintInfo&, const IntRect&) override;
Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.h (183856 => 183857)
--- trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.h 2015-05-06 06:21:20 UTC (rev 183857)
@@ -74,7 +74,7 @@
virtual void updateStyle() override final;
- virtual void paint(PaintInfo&, const LayoutPoint&);
+ virtual void paint(PaintInfo&, const LayoutPoint&) override;
void updateTokenContent(const String& operatorString);
virtual void updateTokenContent() override final;
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGBlock.h (183856 => 183857)
--- trunk/Source/WebCore/rendering/svg/RenderSVGBlock.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGBlock.h 2015-05-06 06:21:20 UTC (rev 183857)
@@ -45,7 +45,7 @@
virtual bool isRenderSVGBlock() const override final { return true; }
- virtual void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedOffset) const;
+ virtual void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedOffset) const override;
virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override final;
};
