Title: [185426] trunk/Source/WebCore
Revision
185426
Author
[email protected]
Date
2015-06-10 11:56:32 -0700 (Wed, 10 Jun 2015)

Log Message

User can not scroll on page when dragging inside video
https://bugs.webkit.org/show_bug.cgi?id=145848
<rdar://problem/20997158>

Reviewed by Brent Fulgham.

Revert the change made in http://trac.webkit.org/changeset/183797
which breaks panning on pages if the touch starts inside the video.

* Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handleWrapperTouchStart): Do not return true, which stops
the handleEvent call in the superclass from preventing the default action.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (185425 => 185426)


--- trunk/Source/WebCore/ChangeLog	2015-06-10 18:44:50 UTC (rev 185425)
+++ trunk/Source/WebCore/ChangeLog	2015-06-10 18:56:32 UTC (rev 185426)
@@ -1,3 +1,18 @@
+2015-06-10  Dean Jackson  <[email protected]>
+
+        User can not scroll on page when dragging inside video
+        https://bugs.webkit.org/show_bug.cgi?id=145848
+        <rdar://problem/20997158>
+
+        Reviewed by Brent Fulgham.
+
+        Revert the change made in http://trac.webkit.org/changeset/183797
+        which breaks panning on pages if the touch starts inside the video.
+
+        * Modules/mediacontrols/mediaControlsiOS.js:
+        (ControllerIOS.prototype.handleWrapperTouchStart): Do not return true, which stops
+        the handleEvent call in the superclass from preventing the default action.
+
 2015-06-10  Matt Rajca  <[email protected]>
 
         Explicitly keep track of active HTMLMediaElements in MediaSessions.

Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js (185425 => 185426)


--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js	2015-06-10 18:44:50 UTC (rev 185425)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js	2015-06-10 18:56:32 UTC (rev 185426)
@@ -353,8 +353,6 @@
             this.hideTimer = setTimeout(this.hideControls.bind(this), this.HideControlsDelay);
         } else if (!this.canPlay())
             this.hideControls();
-
-        return true;
     },
 
     handlePanelTouchStart: function(event) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to