Title: [185427] trunk/Source/_javascript_Core
- Revision
- 185427
- Author
- [email protected]
- Date
- 2015-06-10 13:35:14 -0700 (Wed, 10 Jun 2015)
Log Message
DFG ASSERTION FAILED: !iterate() on stress/singleton-scope-then-overwrite.js.ftl-eager
https://bugs.webkit.org/show_bug.cgi?id=145853
Unreviewed, remove the assertion.
* dfg/DFGCSEPhase.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (185426 => 185427)
--- trunk/Source/_javascript_Core/ChangeLog 2015-06-10 18:56:32 UTC (rev 185426)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-06-10 20:35:14 UTC (rev 185427)
@@ -1,3 +1,12 @@
+2015-06-10 Filip Pizlo <[email protected]>
+
+ DFG ASSERTION FAILED: !iterate() on stress/singleton-scope-then-overwrite.js.ftl-eager
+ https://bugs.webkit.org/show_bug.cgi?id=145853
+
+ Unreviewed, remove the assertion.
+
+ * dfg/DFGCSEPhase.cpp:
+
2015-06-10 Commit Queue <[email protected]>
Unreviewed, rolling out r185414.
Modified: trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp (185426 => 185427)
--- trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp 2015-06-10 18:56:32 UTC (rev 185426)
+++ trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp 2015-06-10 20:35:14 UTC (rev 185427)
@@ -409,25 +409,14 @@
bool changed = iterate();
- // Iterating a second time should not find new CSE opportunities, unless we have a bug.
- if (validationEnabled()) {
- reset();
- DFG_ASSERT(m_graph, nullptr, !iterate());
- }
+ // FIXME: It should be possible to assert that CSE will not find any new opportunities if you
+ // run it a second time. Unfortunately, we cannot assert this right now. Note that if we did
+ // this, we'd have to first reset all of our state.
+ // https://bugs.webkit.org/show_bug.cgi?id=145853
return changed;
}
- void reset()
- {
- m_pureValues.clear();
-
- for (BlockIndex i = m_impureDataMap.size(); i--;) {
- m_impureDataMap[i].availableAtTail.clear();
- m_impureDataMap[i].didVisit = false;
- }
- }
-
bool iterate()
{
if (verbose)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
