Title: [188836] trunk/Tools
Revision
188836
Author
[email protected]
Date
2015-08-23 09:29:45 -0700 (Sun, 23 Aug 2015)

Log Message

build.webkit.org/dashboard: Respect step's hidden flag
https://bugs.webkit.org/show_bug.cgi?id=148357

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype._parseData):

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (188835 => 188836)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js	2015-08-23 16:26:29 UTC (rev 188835)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js	2015-08-23 16:29:45 UTC (rev 188836)
@@ -243,7 +243,7 @@
 
         this.failedTestSteps = [];
         data.steps.forEach(function(step) {
-            if (!step.isFinished || !(step.name in BuildbotIteration.TestSteps))
+            if (!step.isFinished || step.hidden || !(step.name in BuildbotIteration.TestSteps))
                 return;
             var results = new BuildbotTestResults(step);
             if (step.name === "layout-test")
@@ -263,7 +263,7 @@
 
         this.loaded = true;
 
-        this._firstFailedStep = data.steps.findFirst(function(step) { return step.results[0] === BuildbotIteration.FAILURE; });
+        this._firstFailedStep = data.steps.findFirst(function(step) { return !step.hidden && step.results[0] === BuildbotIteration.FAILURE; });
 
         console.assert(data.results === null || typeof data.results === "number");
         this._result = data.results;

Modified: trunk/Tools/ChangeLog (188835 => 188836)


--- trunk/Tools/ChangeLog	2015-08-23 16:26:29 UTC (rev 188835)
+++ trunk/Tools/ChangeLog	2015-08-23 16:29:45 UTC (rev 188836)
@@ -1,3 +1,13 @@
+2015-08-23  Alexey Proskuryakov  <[email protected]>
+
+        build.webkit.org/dashboard: Respect step's hidden flag
+        https://bugs.webkit.org/show_bug.cgi?id=148357
+
+        Reviewed by Darin Adler.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+        (BuildbotIteration.prototype._parseData):
+
 2015-08-23  Nan Wang  <[email protected]>
 
         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to