Title: [188835] trunk
- Revision
- 188835
- Author
- [email protected]
- Date
- 2015-08-23 09:26:29 -0700 (Sun, 23 Aug 2015)
Log Message
AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
https://bugs.webkit.org/show_bug.cgi?id=148328
Patch by Nan Wang <[email protected]> on 2015-08-23
Reviewed by Darin Adler.
Tools:
We should only expose stringValue() when value attribute is set.
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::stringValue):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::stringValue):
LayoutTests:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (188834 => 188835)
--- trunk/LayoutTests/ChangeLog 2015-08-23 10:35:19 UTC (rev 188834)
+++ trunk/LayoutTests/ChangeLog 2015-08-23 16:26:29 UTC (rev 188835)
@@ -1,3 +1,12 @@
+2015-08-23 Nan Wang <[email protected]>
+
+ AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
+ https://bugs.webkit.org/show_bug.cgi?id=148328
+
+ Reviewed by Darin Adler.
+
+ * platform/mac/TestExpectations:
+
2015-08-22 Chris Dumez <[email protected]>
NodeList should not have a named getter
Modified: trunk/LayoutTests/platform/mac/TestExpectations (188834 => 188835)
--- trunk/LayoutTests/platform/mac/TestExpectations 2015-08-23 10:35:19 UTC (rev 188834)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2015-08-23 16:26:29 UTC (rev 188835)
@@ -1255,9 +1255,6 @@
[ ElCapitan+ ] sputnik/Unicode/Unicode_510/S7.6_A5.3_T1.html [ Failure ]
[ ElCapitan+ ] sputnik/Unicode/Unicode_510/S7.6_A5.3_T2.html [ Failure ]
-# <rdar://problem/20417352>
-[ ElCapitan+ ] accessibility/deleting-iframe-destroys-axcache.html [ Pass Failure ]
-
# <rdar://problem/20622665> WebKit media doesn't get a canplay event when load stalls
[ ElCapitan+ ] http/tests/media/video-play-stall.html [ Pass Failure ]
Modified: trunk/Tools/ChangeLog (188834 => 188835)
--- trunk/Tools/ChangeLog 2015-08-23 10:35:19 UTC (rev 188834)
+++ trunk/Tools/ChangeLog 2015-08-23 16:26:29 UTC (rev 188835)
@@ -1,3 +1,17 @@
+2015-08-23 Nan Wang <[email protected]>
+
+ AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
+ https://bugs.webkit.org/show_bug.cgi?id=148328
+
+ Reviewed by Darin Adler.
+
+ We should only expose stringValue() when value attribute is set.
+
+ * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
+ (AccessibilityUIElement::stringValue):
+ * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
+ (WTR::AccessibilityUIElement::stringValue):
+
2015-08-23 Gyuyoung Kim <[email protected]>
Remove style checking rule regarding OwnPtr and PassOwnPtr
Modified: trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm (188834 => 188835)
--- trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm 2015-08-23 10:35:19 UTC (rev 188834)
+++ trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm 2015-08-23 16:26:29 UTC (rev 188835)
@@ -694,7 +694,8 @@
{
BEGIN_AX_OBJC_EXCEPTIONS
id description = descriptionOfValue([m_element accessibilityAttributeValue:NSAccessibilityValueAttribute], m_element);
- return concatenateAttributeAndValue(@"AXValue", description);
+ if (description)
+ return concatenateAttributeAndValue(@"AXValue", description);
END_AX_OBJC_EXCEPTIONS
return nullptr;
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm (188834 => 188835)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2015-08-23 10:35:19 UTC (rev 188834)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2015-08-23 16:26:29 UTC (rev 188835)
@@ -739,7 +739,8 @@
{
BEGIN_AX_OBJC_EXCEPTIONS
id description = descriptionOfValue([m_element accessibilityAttributeValue:NSAccessibilityValueAttribute], m_element);
- return concatenateAttributeAndValue(@"AXValue", description);
+ if (description)
+ return concatenateAttributeAndValue(@"AXValue", description);
END_AX_OBJC_EXCEPTIONS
return nullptr;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
