Title: [190548] trunk/Tools
Revision
190548
Author
[email protected]
Date
2015-10-04 09:57:08 -0700 (Sun, 04 Oct 2015)

Log Message

Bot watcher's dashboard builders should turn yellow when svn fails
https://bugs.webkit.org/show_bug.cgi?id=149791

Reviewed by Lucas Forschler.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
(BuildbotBuilderQueueView.prototype.update):

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js (190547 => 190548)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js	2015-10-04 02:38:19 UTC (rev 190547)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js	2015-10-04 16:57:08 UTC (rev 190548)
@@ -75,7 +75,7 @@
                 && mostRecentFinishedIteration && mostRecentFinishedIteration.loaded) {
                 console.assert(!mostRecentFinishedIteration.successful);
                 var message = this.revisionContentForIteration(mostRecentFinishedIteration, mostRecentFinishedIteration.productive ? mostRecentSuccessfulIteration : null);
-                if (mostRecentFinishedIteration.failed) {
+                if (mostRecentFinishedIteration.failed && mostRecentFinishedIteration.productive) {
                     // Assume it was a build step that failed, and link directly to output.
                     var url = "" log");
                     if (!url)

Modified: trunk/Tools/ChangeLog (190547 => 190548)


--- trunk/Tools/ChangeLog	2015-10-04 02:38:19 UTC (rev 190547)
+++ trunk/Tools/ChangeLog	2015-10-04 16:57:08 UTC (rev 190548)
@@ -1,3 +1,14 @@
+2015-10-04  Alexey Proskuryakov  <[email protected]>
+
+        Bot watcher's dashboard builders should turn yellow when svn fails
+        https://bugs.webkit.org/show_bug.cgi?id=149791
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
+        (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
+        (BuildbotBuilderQueueView.prototype.update):
+
 2015-10-02  Daniel Bates  <[email protected]>
 
         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to