Title: [190549] trunk/Tools
- Revision
- 190549
- Author
- [email protected]
- Date
- 2015-10-04 10:01:01 -0700 (Sun, 04 Oct 2015)
Log Message
Fix some errors on bot watcher's dashboard
https://bugs.webkit.org/show_bug.cgi?id=149789
Reviewed by Lucas Forschler.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (190548 => 190549)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2015-10-04 16:57:08 UTC (rev 190548)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2015-10-04 17:01:01 UTC (rev 190549)
@@ -82,7 +82,11 @@
// A crashes-only queue is a queue where we are only interested in crashes, e.g. a GuardMalloc or an ASan one.
// Currently, only layout tests are supported in such.
var layoutTestResults = iteration.layoutTestResults;
- if (layoutTestResults.tooManyFailures) {
+ if (!layoutTestResults) {
+ // Tests did not run.
+ var url = ""
+ var status = new StatusLineView(messageElement, StatusLineView.Status.Danger, iteration.text, undefined, url);
+ } else if (layoutTestResults.tooManyFailures) {
var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, "failure limit exceeded", undefined, iteration.queue.buildbot.layoutTestResultsURLForIteration(iteration));
new PopoverTracker(status.statusBubbleElement, this._presentPopoverForLayoutTestRegressions.bind(this), iteration);
} else if (layoutTestResults.errorOccurred) {
Modified: trunk/Tools/ChangeLog (190548 => 190549)
--- trunk/Tools/ChangeLog 2015-10-04 16:57:08 UTC (rev 190548)
+++ trunk/Tools/ChangeLog 2015-10-04 17:01:01 UTC (rev 190549)
@@ -1,5 +1,16 @@
2015-10-04 Alexey Proskuryakov <[email protected]>
+ Fix some errors on bot watcher's dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=149789
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+ (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
+ tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
+
+2015-10-04 Alexey Proskuryakov <[email protected]>
+
Bot watcher's dashboard builders should turn yellow when svn fails
https://bugs.webkit.org/show_bug.cgi?id=149791
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
