Title: [190551] trunk
- Revision
- 190551
- Author
- [email protected]
- Date
- 2015-10-04 11:33:21 -0700 (Sun, 04 Oct 2015)
Log Message
Web Inspector: Wrong column numbers in error object views
https://bugs.webkit.org/show_bug.cgi?id=149795
Source/WebInspectorUI:
Convert columnNumber and lineNumber properties from strings to numbers
to prevent accidental string concatenations.
Reviewed by Timothy Hatcher.
* UserInterface/Models/StackTrace.js:
(WebInspector.StackTrace._parseStackTrace):
LayoutTests:
Reviewed by Timothy Hatcher.
* inspector/debugger/js-stacktrace-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (190550 => 190551)
--- trunk/LayoutTests/ChangeLog 2015-10-04 17:49:08 UTC (rev 190550)
+++ trunk/LayoutTests/ChangeLog 2015-10-04 18:33:21 UTC (rev 190551)
@@ -1,3 +1,12 @@
+2015-10-04 Nikita Vasilyev <[email protected]>
+
+ Web Inspector: Wrong column numbers in error object views
+ https://bugs.webkit.org/show_bug.cgi?id=149795
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/debugger/js-stacktrace-expected.txt:
+
2015-10-03 Alexey Proskuryakov <[email protected]>
fast/events/overflow-scroll-fake-mouse-move.html is flaky
Modified: trunk/LayoutTests/inspector/debugger/js-stacktrace-expected.txt (190550 => 190551)
--- trunk/LayoutTests/inspector/debugger/js-stacktrace-expected.txt 2015-10-04 17:49:08 UTC (rev 190550)
+++ trunk/LayoutTests/inspector/debugger/js-stacktrace-expected.txt 2015-10-04 18:33:21 UTC (rev 190551)
@@ -21,14 +21,14 @@
{
"functionName": "typeError",
"url": "/inspector/debugger/js-stacktrace.html",
- "lineNumber": "14",
- "columnNumber": "30"
+ "lineNumber": 14,
+ "columnNumber": 30
},
{
"functionName": "typeErrorWrap",
"url": "/inspector/debugger/js-stacktrace.html",
- "lineNumber": "7",
- "columnNumber": "21"
+ "lineNumber": 7,
+ "columnNumber": 21
}
]
@@ -59,8 +59,8 @@
{
"functionName": "typeError",
"url": "/inspector/debugger/js-stacktrace.html",
- "lineNumber": "14",
- "columnNumber": "30"
+ "lineNumber": 14,
+ "columnNumber": 30
},
{
"functionName": "map",
Modified: trunk/Source/WebInspectorUI/ChangeLog (190550 => 190551)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-10-04 17:49:08 UTC (rev 190550)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-10-04 18:33:21 UTC (rev 190551)
@@ -1,3 +1,16 @@
+2015-10-04 Nikita Vasilyev <[email protected]>
+
+ Web Inspector: Wrong column numbers in error object views
+ https://bugs.webkit.org/show_bug.cgi?id=149795
+
+ Convert columnNumber and lineNumber properties from strings to numbers
+ to prevent accidental string concatenations.
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Models/StackTrace.js:
+ (WebInspector.StackTrace._parseStackTrace):
+
2015-10-02 Matt Baker <[email protected]>
Web Inspector: Add breakpoint option to ignore n times before stopping
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js (190550 => 190551)
--- trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js 2015-10-04 17:49:08 UTC (rev 190550)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js 2015-10-04 18:33:21 UTC (rev 190551)
@@ -66,12 +66,12 @@
var columnIndex = url.lastIndexOf(":");
if (columnIndex !== -1) {
- columnNumber = url.slice(columnIndex + 1);
+ columnNumber = parseInt(url.slice(columnIndex + 1));
url = "" columnIndex);
var lineIndex = url.lastIndexOf(":", columnIndex);
if (lineIndex !== -1) {
- lineNumber = url.slice(lineIndex + 1, columnIndex);
+ lineNumber = parseInt(url.slice(lineIndex + 1, columnIndex));
url = "" lineIndex);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
