Title: [190550] trunk/Tools
- Revision
- 190550
- Author
- [email protected]
- Date
- 2015-10-04 10:49:08 -0700 (Sun, 04 Oct 2015)
Log Message
Support Trac 1.0.x XML timeline link format
https://bugs.webkit.org/show_bug.cgi?id=149786
Reviewed by Lucas Forschler.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype._convertCommitInfoElementToObject):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js (190549 => 190550)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js 2015-10-04 17:01:01 UTC (rev 190549)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js 2015-10-04 17:49:08 UTC (rev 190550)
@@ -90,8 +90,15 @@
_convertCommitInfoElementToObject: function(doc, commitElement)
{
var link = doc.evaluate("./link", commitElement, null, XPathResult.STRING_TYPE).stringValue;
- var revisionNumber = parseInt(/\d+$/.exec(link))
+ // There are multiple link formats for Trac that we support:
+ // https://trac.webkit.org/changeset/190497
+ // http://trac.foobar.com/repository/changeset/75388/project
+ var linkComponents = link.split("/");
+ var revisionNumber = parseInt(linkComponents.pop());
+ if (!revisionNumber)
+ var revisionNumber = parseInt(linkComponents.pop());
+
function tracNSResolver(prefix)
{
if (prefix == "dc")
Modified: trunk/Tools/ChangeLog (190549 => 190550)
--- trunk/Tools/ChangeLog 2015-10-04 17:01:01 UTC (rev 190549)
+++ trunk/Tools/ChangeLog 2015-10-04 17:49:08 UTC (rev 190550)
@@ -1,5 +1,15 @@
2015-10-04 Alexey Proskuryakov <[email protected]>
+ Support Trac 1.0.x XML timeline link format
+ https://bugs.webkit.org/show_bug.cgi?id=149786
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
+ (Trac.prototype._convertCommitInfoElementToObject):
+
+2015-10-04 Alexey Proskuryakov <[email protected]>
+
Fix some errors on bot watcher's dashboard
https://bugs.webkit.org/show_bug.cgi?id=149789
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
