Title: [191524] trunk/LayoutTests
Revision
191524
Author
[email protected]
Date
2015-10-23 17:46:06 -0700 (Fri, 23 Oct 2015)

Log Message

Remove unnecessary details from Other Crashes section
https://bugs.webkit.org/show_bug.cgi?id=150514
<rdar://problem/23235458>

Patch by Aakash Jain <[email protected]> on 2015-10-23
Reviewed by Alexey Proskuryakov.

* fast/harness/results.html: Create separate other-crash-tests-table.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (191523 => 191524)


--- trunk/LayoutTests/ChangeLog	2015-10-24 00:44:23 UTC (rev 191523)
+++ trunk/LayoutTests/ChangeLog	2015-10-24 00:46:06 UTC (rev 191524)
@@ -1,3 +1,13 @@
+2015-10-23  Aakash Jain  <[email protected]>
+
+        Remove unnecessary details from Other Crashes section
+        https://bugs.webkit.org/show_bug.cgi?id=150514
+        <rdar://problem/23235458>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * fast/harness/results.html: Create separate other-crash-tests-table.
+
 2015-10-23  Ryan Haddad  <[email protected]>
 
         Marking more http/tests/xmlhttprequest/timeout/ tests as flaky, removing Yosemite-only flag

Modified: trunk/LayoutTests/fast/harness/results.html (191523 => 191524)


--- trunk/LayoutTests/fast/harness/results.html	2015-10-24 00:44:23 UTC (rev 191523)
+++ trunk/LayoutTests/fast/harness/results.html	2015-10-24 00:46:06 UTC (rev 191524)
@@ -494,6 +494,11 @@
     return '<span class=expand-button _onclick_="toggleExpectations(this)"><span class=expand-button-text>+</span></span>' + testLink(test);
 }
 
+function testWithExpandButton(test)
+{
+    return '<span class=expand-button _onclick_="toggleExpectations(this)"><span class=expand-button-text>+</span></span>' + test;
+}
+
 function resultLink(testPrefix, suffix, contents)
 {
     return '<a class=result-link href="" + testPrefix + suffix + '" data-prefix="' + testPrefix + '">' + contents + '</a> ';
@@ -769,13 +774,21 @@
         if (globalState().results.uses_expectations_file)
             html += ' class="' + ((testObject.isExpected && tableId != 'stderr-table') ? 'expected' : '') + '"';
         html += '><tr><td>';
-        html += (tableId == 'passes-table') ? testLink(test) : testLinkWithExpandButton(test);
+        if (tableId == 'passes-table')
+            html += testLink(test);
+        else if (tableId == 'other-crash-tests-table')
+            html += testWithExpandButton(test);
+        else
+            html += testLinkWithExpandButton(test);
+
         html += '</td><td>';
 
         if (tableId == 'stderr-table')
             html += resultLink(stripExtension(test), '-stderr.txt', 'stderr');
         else if (tableId == 'passes-table')
             html += testObject.expected;
+        else if (tableId == 'other-crash-tests-table') 
+            html += resultLink(stripExtension(test), '-crash-log.txt', 'crash log');
         else if (tableId == 'crash-tests-table') {
             html += resultLink(stripExtension(test), '-crash-log.txt', 'crash log');
             html += resultLink(stripExtension(test), '-sample.txt', 'sample');
@@ -784,7 +797,8 @@
             html += textResultLinks(stripExtension(test));
         }
 
-        html += '</td><td><a href="" + flakinessDashboardURLForTests([testObject]) + '">history</a></td>';
+        if (tableId != 'other-crash-tests-table')
+            html += '</td><td><a href="" + flakinessDashboardURLForTests([testObject]) + '">history</a></td>';
 
         html += '</tr></tbody>';
     }
@@ -1386,7 +1400,7 @@
         html += testList(globalState().crashTests, 'Tests that crashed', 'crash-tests-table');
 
     if (globalState().crashOther.length)
-        html += testList(globalState().crashOther, 'Other Crashes', 'crash-tests-table');
+        html += testList(globalState().crashOther, 'Other Crashes', 'other-crash-tests-table');
 
     html += failingTestsTable(globalState().failingTests,
         'Tests that failed text/pixel/audio diff', 'results-table');
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to