Title: [191525] trunk/Source/WebCore
- Revision
- 191525
- Author
- [email protected]
- Date
- 2015-10-23 17:52:41 -0700 (Fri, 23 Oct 2015)
Log Message
Avoid SVG-induced layouts inside Element::absoluteEventBounds()
https://bugs.webkit.org/show_bug.cgi?id=150516
Reviewed by Zalan Bujtas.
Speculative fix for a crash under RenderObject::localToContainerQuad() when
computing the wheel event handler region, which uses Element::absoluteEventHandlerBounds().
Element::absoluteEventBounds() was calling SVGElement::getBoundingBox() in a way
that could trigger a layout.
* dom/Element.cpp:
(WebCore::Element::absoluteEventBounds):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (191524 => 191525)
--- trunk/Source/WebCore/ChangeLog 2015-10-24 00:46:06 UTC (rev 191524)
+++ trunk/Source/WebCore/ChangeLog 2015-10-24 00:52:41 UTC (rev 191525)
@@ -1,3 +1,18 @@
+2015-10-23 Simon Fraser <[email protected]>
+
+ Avoid SVG-induced layouts inside Element::absoluteEventBounds()
+ https://bugs.webkit.org/show_bug.cgi?id=150516
+
+ Reviewed by Zalan Bujtas.
+
+ Speculative fix for a crash under RenderObject::localToContainerQuad() when
+ computing the wheel event handler region, which uses Element::absoluteEventHandlerBounds().
+ Element::absoluteEventBounds() was calling SVGElement::getBoundingBox() in a way
+ that could trigger a layout.
+
+ * dom/Element.cpp:
+ (WebCore::Element::absoluteEventBounds):
+
2015-10-23 Alex Christensen <[email protected]>
Progress towards CMake on Mac
Modified: trunk/Source/WebCore/dom/Element.cpp (191524 => 191525)
--- trunk/Source/WebCore/dom/Element.cpp 2015-10-24 00:46:06 UTC (rev 191524)
+++ trunk/Source/WebCore/dom/Element.cpp 2015-10-24 00:52:41 UTC (rev 191525)
@@ -975,7 +975,7 @@
// Get the bounding rectangle from the SVG model.
SVGElement& svgElement = downcast<SVGElement>(*this);
FloatRect localRect;
- if (svgElement.getBoundingBox(localRect))
+ if (svgElement.getBoundingBox(localRect, SVGLocatable::DisallowStyleUpdate))
result = LayoutRect(renderer()->localToAbsoluteQuad(localRect, UseTransforms, &includesFixedPositionElements).boundingBox());
} else {
if (is<RenderBox>(renderer())) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes