Title: [191973] trunk/Source
- Revision
- 191973
- Author
- commit-qu...@webkit.org
- Date
- 2015-11-03 13:37:40 -0800 (Tue, 03 Nov 2015)
Log Message
Web Inspector: Move ScriptDebugServer::Task to WorkerScriptDebugServer where it is actually used
https://bugs.webkit.org/show_bug.cgi?id=150847
Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-11-03
Reviewed by Timothy Hatcher.
Source/_javascript_Core:
* inspector/ScriptDebugServer.h:
Remove Task from here, it isn't needed in the general case.
* parser/SourceProvider.h:
Remove unimplemented method.
Source/WebCore:
* bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::interruptAndRunTask):
* bindings/js/WorkerScriptDebugServer.h:
* inspector/WorkerDebuggerAgent.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (191972 => 191973)
--- trunk/Source/_javascript_Core/ChangeLog 2015-11-03 21:28:55 UTC (rev 191972)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-11-03 21:37:40 UTC (rev 191973)
@@ -1,5 +1,18 @@
2015-11-03 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Move ScriptDebugServer::Task to WorkerScriptDebugServer where it is actually used
+ https://bugs.webkit.org/show_bug.cgi?id=150847
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/ScriptDebugServer.h:
+ Remove Task from here, it isn't needed in the general case.
+
+ * parser/SourceProvider.h:
+ Remove unimplemented method.
+
+2015-11-03 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: Handle or Remove ParseHTML Timeline Event Records
https://bugs.webkit.org/show_bug.cgi?id=150689
Modified: trunk/Source/_javascript_Core/inspector/ScriptDebugServer.h (191972 => 191973)
--- trunk/Source/_javascript_Core/inspector/ScriptDebugServer.h 2015-11-03 21:28:55 UTC (rev 191972)
+++ trunk/Source/_javascript_Core/inspector/ScriptDebugServer.h 2015-11-03 21:37:40 UTC (rev 191973)
@@ -59,13 +59,6 @@
const BreakpointActions& getActionsForBreakpoint(JSC::BreakpointID);
- class Task {
- WTF_MAKE_FAST_ALLOCATED;
- public:
- virtual ~Task() { }
- virtual void run() = 0;
- };
-
protected:
typedef HashSet<ScriptDebugListener*> ListenerSet;
typedef void (ScriptDebugServer::*_javascript_ExecutionCallback)(ScriptDebugListener*);
Modified: trunk/Source/_javascript_Core/parser/SourceProvider.h (191972 => 191973)
--- trunk/Source/_javascript_Core/parser/SourceProvider.h 2015-11-03 21:28:55 UTC (rev 191972)
+++ trunk/Source/_javascript_Core/parser/SourceProvider.h 2015-11-03 21:37:40 UTC (rev 191973)
@@ -71,7 +71,6 @@
void setSourceMappingURLDirective(const String& sourceMappingURL) { m_sourceMappingURLDirective = sourceMappingURL; }
JS_EXPORT_PRIVATE void getID();
- Vector<size_t>& lineStarts();
String m_url;
String m_sourceURLDirective;
Modified: trunk/Source/WebCore/ChangeLog (191972 => 191973)
--- trunk/Source/WebCore/ChangeLog 2015-11-03 21:28:55 UTC (rev 191972)
+++ trunk/Source/WebCore/ChangeLog 2015-11-03 21:37:40 UTC (rev 191973)
@@ -1,3 +1,15 @@
+2015-11-03 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Move ScriptDebugServer::Task to WorkerScriptDebugServer where it is actually used
+ https://bugs.webkit.org/show_bug.cgi?id=150847
+
+ Reviewed by Timothy Hatcher.
+
+ * bindings/js/WorkerScriptDebugServer.cpp:
+ (WebCore::WorkerScriptDebugServer::interruptAndRunTask):
+ * bindings/js/WorkerScriptDebugServer.h:
+ * inspector/WorkerDebuggerAgent.cpp:
+
2015-11-03 Tim Horton <timothy_hor...@apple.com>
Fix the build.
Modified: trunk/Source/WebCore/bindings/js/WorkerScriptDebugServer.cpp (191972 => 191973)
--- trunk/Source/WebCore/bindings/js/WorkerScriptDebugServer.cpp 2015-11-03 21:28:55 UTC (rev 191972)
+++ trunk/Source/WebCore/bindings/js/WorkerScriptDebugServer.cpp 2015-11-03 21:37:40 UTC (rev 191973)
@@ -102,7 +102,7 @@
WebCore::reportException(exec, exception);
}
-void WorkerScriptDebugServer::interruptAndRunTask(std::unique_ptr<ScriptDebugServer::Task>)
+void WorkerScriptDebugServer::interruptAndRunTask(std::unique_ptr<Task>)
{
}
Modified: trunk/Source/WebCore/bindings/js/WorkerScriptDebugServer.h (191972 => 191973)
--- trunk/Source/WebCore/bindings/js/WorkerScriptDebugServer.h 2015-11-03 21:28:55 UTC (rev 191972)
+++ trunk/Source/WebCore/bindings/js/WorkerScriptDebugServer.h 2015-11-03 21:37:40 UTC (rev 191973)
@@ -43,12 +43,19 @@
WorkerScriptDebugServer(WorkerGlobalScope&, const String&);
~WorkerScriptDebugServer() { }
+ class Task {
+ WTF_MAKE_FAST_ALLOCATED;
+ public:
+ virtual ~Task() { }
+ virtual void run() = 0;
+ };
+
virtual void recompileAllJSFunctions() override;
void addListener(Inspector::ScriptDebugListener*);
void removeListener(Inspector::ScriptDebugListener*, bool skipRecompile);
- void interruptAndRunTask(std::unique_ptr<ScriptDebugServer::Task>);
+ void interruptAndRunTask(std::unique_ptr<Task>);
private:
virtual ListenerSet& getListeners() override { return m_listeners; }
Modified: trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp (191972 => 191973)
--- trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp 2015-11-03 21:28:55 UTC (rev 191972)
+++ trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp 2015-11-03 21:37:40 UTC (rev 191973)
@@ -58,7 +58,7 @@
return agents;
}
-class RunInspectorCommandsTask : public ScriptDebugServer::Task {
+class RunInspectorCommandsTask : public WorkerScriptDebugServer::Task {
public:
RunInspectorCommandsTask(WorkerThread* thread, WorkerGlobalScope* workerGlobalScope)
: m_thread(thread)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes