Title: [193231] branches/safari-601-branch/Source/WebInspectorUI
- Revision
- 193231
- Author
- [email protected]
- Date
- 2015-12-03 11:00:06 -0800 (Thu, 03 Dec 2015)
Log Message
Merge r190285. rdar://problem/23221163
Modified Paths
Diff
Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (193230 => 193231)
--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog 2015-12-03 19:00:02 UTC (rev 193230)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog 2015-12-03 19:00:06 UTC (rev 193231)
@@ -1,5 +1,22 @@
2015-12-02 Timothy Hatcher <[email protected]>
+ Merge r190285. rdar://problem/23221163
+
+ 2015-09-28 João Oliveira <[email protected]>
+
+ Web Inspector: search shortcut in split console moves focus to search box, but doesn't show caret
+ https://bugs.webkit.org/show_bug.cgi?id=149223
+
+ Reviewed by Timothy Hatcher.
+
+ When pressing console find shortcut (CMD+F) SearchBar now checks if there's text on _searchInput
+ if so text is selected, if the textbox is empty, textbox gains focus.
+
+ * UserInterface/Views/SearchBar.js:
+ (WebInspector.SearchBar.prototype.focus):
+
+2015-12-02 Timothy Hatcher <[email protected]>
+
Merge r190186. rdar://problem/23221163
2015-09-23 Saam barati <[email protected]>
Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SearchBar.js (193230 => 193231)
--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SearchBar.js 2015-12-03 19:00:02 UTC (rev 193230)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SearchBar.js 2015-12-03 19:00:06 UTC (rev 193231)
@@ -61,8 +61,11 @@
focus()
{
- this._searchInput.focus();
- this._searchInput.select();
+ // FIXME: Workaround for: <https://webkit.org/b/149504> Caret missing from <input> after clearing text and calling select()
+ if (!this._searchInput.value.length)
+ this._searchInput.focus();
+ else
+ this._searchInput.select();
}
// Private
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
