[webkit-changes] [193230] branches/safari-601-branch/Source/WebInspectorUI

Thu, 03 Dec 2015 11:00:12 -0800

Title: [193230] branches/safari-601-branch/Source/WebInspectorUI
Revision
193230
Author
[email protected]
Date
2015-12-03 11:00:02 -0800 (Thu, 03 Dec 2015)

Log Message

Merge r190186. rdar://problem/23221163


Modified Paths

Diff

Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (193229 => 193230)


--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-12-03 18:59:57 UTC (rev 193229)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-12-03 19:00:02 UTC (rev 193230)
@@ -1,5 +1,20 @@
 2015-12-02  Timothy Hatcher  <[email protected]>
 
+        Merge r190186. rdar://problem/23221163
+
+    2015-09-23  Saam barati  <[email protected]>
+
+            Web Inspector: Don't use bind() when creating internal AST, instead, pass in "this" parameter to map()
+            https://bugs.webkit.org/show_bug.cgi?id=149483
+
+            Reviewed by Joseph Pecoraro.
+
+            * UserInterface/Models/ScriptSyntaxTree.js:
+            (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
+            (WebInspector.ScriptSyntaxTree):
+
+2015-12-02  Timothy Hatcher  <[email protected]>
+
         Merge r190184. rdar://problem/23221163
 
     2015-09-23  Saam barati  <[email protected]>

Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js (193229 => 193230)


--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js	2015-12-03 18:59:57 UTC (rev 193229)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js	2015-12-03 19:00:02 UTC (rev 193230)
@@ -530,21 +530,21 @@
         case "ArrayExpression":
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.ArrayExpression,
-                elements: node.elements.map(this._createInternalSyntaxTree.bind(this))
+                elements: node.elements.map(this._createInternalSyntaxTree, this)
             };
             break;
         case "ArrayPattern":
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.ArrayPattern,
-                elements: node.elements.map(this._createInternalSyntaxTree.bind(this))
+                elements: node.elements.map(this._createInternalSyntaxTree, this)
             };
             break;
         case "ArrowFunctionExpression":
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.ArrowFunctionExpression,
                 id: this._createInternalSyntaxTree(node.id),
-                params: node.params.map(this._createInternalSyntaxTree.bind(this)),
-                defaults: node.defaults.map(this._createInternalSyntaxTree.bind(this)),
+                params: node.params.map(this._createInternalSyntaxTree, this),
+                defaults: node.defaults.map(this._createInternalSyntaxTree, this),
                 body: this._createInternalSyntaxTree(node.body),
                 _expression_: node._expression_, // Boolean indicating if the body a single _expression_ or a block statement.
                 typeProfilingReturnDivot: node.range[0]
@@ -568,7 +568,7 @@
         case "BlockStatement":
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.BlockStatement,
-                body: node.body.map(this._createInternalSyntaxTree.bind(this))
+                body: node.body.map(this._createInternalSyntaxTree, this)
             };
             break;
         case "BinaryExpression":
@@ -589,7 +589,7 @@
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.CallExpression,
                 callee: this._createInternalSyntaxTree(node.callee),
-                arguments: node.arguments.map(this._createInternalSyntaxTree.bind(this))
+                arguments: node.arguments.map(this._createInternalSyntaxTree, this)
             };
             break;
         case "CatchClause":
@@ -602,7 +602,7 @@
         case "ClassBody":
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.ClassBody,
-                body: node.body.map(this._createInternalSyntaxTree.bind(this))
+                body: node.body.map(this._createInternalSyntaxTree, this)
             };
             break;
         case "ClassDeclaration":
@@ -687,8 +687,8 @@
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.FunctionDeclaration,
                 id: this._createInternalSyntaxTree(node.id),
-                params: node.params.map(this._createInternalSyntaxTree.bind(this)),
-                defaults: node.defaults.map(this._createInternalSyntaxTree.bind(this)),
+                params: node.params.map(this._createInternalSyntaxTree, this),
+                defaults: node.defaults.map(this._createInternalSyntaxTree, this),
                 body: this._createInternalSyntaxTree(node.body),
                 typeProfilingReturnDivot: node.range[0]
             };
@@ -697,8 +697,8 @@
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.FunctionExpression,
                 id: this._createInternalSyntaxTree(node.id),
-                params: node.params.map(this._createInternalSyntaxTree.bind(this)),
-                defaults: node.defaults.map(this._createInternalSyntaxTree.bind(this)),
+                params: node.params.map(this._createInternalSyntaxTree, this),
+                defaults: node.defaults.map(this._createInternalSyntaxTree, this),
                 body: this._createInternalSyntaxTree(node.body),
                 typeProfilingReturnDivot: node.range[0] // This may be overridden in the Property AST node.
             };
@@ -770,26 +770,26 @@
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.NewExpression,
                 callee: this._createInternalSyntaxTree(node.callee),
-                arguments: node.arguments.map(this._createInternalSyntaxTree.bind(this))
+                arguments: node.arguments.map(this._createInternalSyntaxTree, this)
             };
             break;
         case "ObjectExpression":
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.ObjectExpression,
-                properties: node.properties.map(this._createInternalSyntaxTree.bind(this))
+                properties: node.properties.map(this._createInternalSyntaxTree, this)
             };
             break;
         case "ObjectPattern":
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.ObjectPattern,
-                properties: node.properties.map(this._createInternalSyntaxTree.bind(this))
+                properties: node.properties.map(this._createInternalSyntaxTree, this)
             };
             break;
         case "Program":
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.Program,
                 sourceType: node.sourceType,
-                body: node.body.map(this._createInternalSyntaxTree.bind(this))
+                body: node.body.map(this._createInternalSyntaxTree, this)
             };
             break;
         case "Property":
@@ -813,7 +813,7 @@
         case "SequenceExpression":
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.SequenceExpression,
-                expressions: node.expressions.map(this._createInternalSyntaxTree.bind(this))
+                expressions: node.expressions.map(this._createInternalSyntaxTree, this)
             };
             break;
         case "SpreadElement":
@@ -831,14 +831,14 @@
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.SwitchStatement,
                 discriminant: this._createInternalSyntaxTree(node.discriminant),
-                cases: node.cases.map(this._createInternalSyntaxTree.bind(this))
+                cases: node.cases.map(this._createInternalSyntaxTree, this)
             };
             break;
         case "SwitchCase":
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.SwitchCase,
                 test: this._createInternalSyntaxTree(node.test),
-                consequent: node.consequent.map(this._createInternalSyntaxTree.bind(this))
+                consequent: node.consequent.map(this._createInternalSyntaxTree, this)
             };
             break;
         case "TaggedTemplateExpression":
@@ -858,8 +858,8 @@
         case "TemplateLiteral":
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.TemplateLiteral,
-                quasis: node.quasis.map(this._createInternalSyntaxTree.bind(this)),
-                expressions: node.expressions.map(this._createInternalSyntaxTree.bind(this))
+                quasis: node.quasis.map(this._createInternalSyntaxTree, this),
+                expressions: node.expressions.map(this._createInternalSyntaxTree, this)
             };
             break;
         case "ThisExpression":
@@ -899,7 +899,7 @@
         case "VariableDeclaration":
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.VariableDeclaration,
-                declarations: node.declarations.map(this._createInternalSyntaxTree.bind(this)),
+                declarations: node.declarations.map(this._createInternalSyntaxTree, this),
                 kind: node.kind
             };
             break;

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to