Title: [194353] trunk/Source/_javascript_Core
- Revision
- 194353
- Author
- [email protected]
- Date
- 2015-12-21 15:32:57 -0800 (Mon, 21 Dec 2015)
Log Message
Unreviewed, remove highBitsAreZero(), it's unused.
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::shouldCopyPropagate):
(JSC::B3::Air::LowerToAir::highBitsAreZero): Deleted.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (194352 => 194353)
--- trunk/Source/_javascript_Core/ChangeLog 2015-12-21 23:05:28 UTC (rev 194352)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-12-21 23:32:57 UTC (rev 194353)
@@ -1,3 +1,12 @@
+2015-12-21 Filip Pizlo <[email protected]>
+
+ Unreviewed, remove highBitsAreZero(), it's unused.
+
+ * b3/B3LowerToAir.cpp:
+ (JSC::B3::Air::LowerToAir::run):
+ (JSC::B3::Air::LowerToAir::shouldCopyPropagate):
+ (JSC::B3::Air::LowerToAir::highBitsAreZero): Deleted.
+
2015-12-21 Csaba Osztrogonác <[email protected]>
Unreviewed, fix the !FTL_USES_B3 build after r194334.
Modified: trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp (194352 => 194353)
--- trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp 2015-12-21 23:05:28 UTC (rev 194352)
+++ trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp 2015-12-21 23:32:57 UTC (rev 194353)
@@ -132,32 +132,6 @@
}
private:
- bool highBitsAreZero(Value* value)
- {
- switch (value->opcode()) {
- case Const32:
- // We will use a Move immediate instruction, which may sign extend.
- return value->asInt32() >= 0;
- case Trunc:
- // Trunc is copy-propagated, so the value may have garbage in the high bits.
- return false;
- case CCall:
- // Calls are allowed to have garbage in their high bits.
- return false;
- case Patchpoint:
- // For now, we assume that patchpoints may return garbage in the high bits. This simplifies
- // the interface. We may revisit for performance reasons later.
- return false;
- case Phi:
- // FIXME: We could do this right.
- // https://bugs.webkit.org/show_bug.cgi?id=150845
- return false;
- default:
- // All other operations that return Int32 should lower to something that zero extends.
- return value->type() == Int32;
- }
- }
-
bool shouldCopyPropagate(Value* value)
{
switch (value->opcode()) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
