Title: [196060] trunk
- Revision
- 196060
- Author
- [email protected]
- Date
- 2016-02-03 02:31:27 -0800 (Wed, 03 Feb 2016)
Log Message
REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
https://bugs.webkit.org/show_bug.cgi?id=152797
Reviewed by Darin Adler.
Source/WebCore:
Always schedule messages to the main thread, even when the bus
sync handlder was called in the main thread. It seems that
GStreamer expects things to happen in the next main loop
iteration.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
LayoutTests:
Update test expectations.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (196059 => 196060)
--- trunk/LayoutTests/ChangeLog 2016-02-03 09:56:54 UTC (rev 196059)
+++ trunk/LayoutTests/ChangeLog 2016-02-03 10:31:27 UTC (rev 196060)
@@ -1,3 +1,14 @@
+2016-02-03 Carlos Garcia Campos <[email protected]>
+
+ REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
+ https://bugs.webkit.org/show_bug.cgi?id=152797
+
+ Reviewed by Darin Adler.
+
+ Update test expectations.
+
+ * platform/gtk/TestExpectations:
+
2016-02-02 Fujii Hironori <[email protected]>
ASSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result)
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (196059 => 196060)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2016-02-03 09:56:54 UTC (rev 196059)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2016-02-03 10:31:27 UTC (rev 196060)
@@ -1489,10 +1489,7 @@
webkit.org/b/144690 editing/spelling/spelling-with-punctuation-selection.html [ Timeout ]
webkit.org/b/144690 editing/spelling/delete-into-misspelled-word.html [ Timeout Pass ]
-webkit.org/b/141835 media/video-controls-no-scripting.html [ Failure Timeout ]
-webkit.org/b/152797 media/video-source-error.html [ Timeout ]
-webkit.org/b/152797 media/video-source-load.html [ Timeout ]
-webkit.org/b/152797 media/video-source-moved.html [ Timeout ]
+webkit.org/b/141835 media/video-controls-no-scripting.html [ Failure ]
# May take too long on the bots.
Bug(GTK) mathml/very-large-stretchy-operators.html [ Pass Timeout ]
Modified: trunk/Source/WebCore/ChangeLog (196059 => 196060)
--- trunk/Source/WebCore/ChangeLog 2016-02-03 09:56:54 UTC (rev 196059)
+++ trunk/Source/WebCore/ChangeLog 2016-02-03 10:31:27 UTC (rev 196060)
@@ -1,3 +1,18 @@
+2016-02-03 Carlos Garcia Campos <[email protected]>
+
+ REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
+ https://bugs.webkit.org/show_bug.cgi?id=152797
+
+ Reviewed by Darin Adler.
+
+ Always schedule messages to the main thread, even when the bus
+ sync handlder was called in the main thread. It seems that
+ GStreamer expects things to happen in the next main loop
+ iteration.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
+
2016-02-03 Zan Dobersek <[email protected]>
[TexMap] CompositingCoordinator should store the overlay layer, flush it as appropriate
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (196059 => 196060)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2016-02-03 09:56:54 UTC (rev 196059)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2016-02-03 10:31:27 UTC (rev 196060)
@@ -1903,16 +1903,12 @@
auto& player = *static_cast<MediaPlayerPrivateGStreamer*>(userData);
if (!player.handleSyncMessage(message)) {
- if (isMainThread())
- player.handleMessage(message);
- else {
- GRefPtr<GstMessage> protectMessage(message);
- auto weakThis = player.createWeakPtr();
- RunLoop::main().dispatch([weakThis, protectMessage] {
- if (weakThis)
- weakThis->handleMessage(protectMessage.get());
- });
- }
+ GRefPtr<GstMessage> protectedMessage(message);
+ auto weakThis = player.createWeakPtr();
+ RunLoop::main().dispatch([weakThis, protectedMessage] {
+ if (weakThis)
+ weakThis->handleMessage(protectedMessage.get());
+ });
}
gst_message_unref(message);
return GST_BUS_DROP;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
