Title: [196061] trunk
- Revision
- 196061
- Author
- [email protected]
- Date
- 2016-02-03 02:37:12 -0800 (Wed, 03 Feb 2016)
Log Message
[GTK] Layout Test http/tests/appcache/different-https-origin-resource-main.html is failing
https://bugs.webkit.org/show_bug.cgi?id=145253
Reviewed by Michael Catanzaro.
Source/WebCore:
The problem is that when the load is cancelled while the
connection is still being established,
SoupMessage::notify::tls-errors is emitted and the handler calls
ResourceHandleClient::didFail() which can delete the ResourceHandle.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::tlsErrorsChangedCallback): Protect the ResourceHandle
for the scope of the callback because
ResourceHandleClient::didFail() could delete the object.
LayoutTests:
Update test expectation.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (196060 => 196061)
--- trunk/LayoutTests/ChangeLog 2016-02-03 10:31:27 UTC (rev 196060)
+++ trunk/LayoutTests/ChangeLog 2016-02-03 10:37:12 UTC (rev 196061)
@@ -1,5 +1,16 @@
2016-02-03 Carlos Garcia Campos <[email protected]>
+ [GTK] Layout Test http/tests/appcache/different-https-origin-resource-main.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=145253
+
+ Reviewed by Michael Catanzaro.
+
+ Update test expectation.
+
+ * platform/gtk/TestExpectations:
+
+2016-02-03 Carlos Garcia Campos <[email protected]>
+
REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
https://bugs.webkit.org/show_bug.cgi?id=152797
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (196060 => 196061)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2016-02-03 10:31:27 UTC (rev 196060)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2016-02-03 10:37:12 UTC (rev 196061)
@@ -1748,7 +1748,7 @@
webkit.org/b/123431 http/tests/local/link-stylesheet-load-order-preload.html [ Failure ]
webkit.org/b/123431 http/tests/local/link-stylesheet-load-order.html [ Failure Pass ]
-webkit.org/b/145253 http/tests/appcache/different-https-origin-resource-main.html [ Failure Crash ]
+webkit.org/b/145253 http/tests/appcache/different-https-origin-resource-main.html [ Failure ]
#////////////////////////////////////////////////////////////////////////////////////////
# Tests failing
Modified: trunk/Source/WebCore/ChangeLog (196060 => 196061)
--- trunk/Source/WebCore/ChangeLog 2016-02-03 10:31:27 UTC (rev 196060)
+++ trunk/Source/WebCore/ChangeLog 2016-02-03 10:37:12 UTC (rev 196061)
@@ -1,5 +1,22 @@
2016-02-03 Carlos Garcia Campos <[email protected]>
+ [GTK] Layout Test http/tests/appcache/different-https-origin-resource-main.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=145253
+
+ Reviewed by Michael Catanzaro.
+
+ The problem is that when the load is cancelled while the
+ connection is still being established,
+ SoupMessage::notify::tls-errors is emitted and the handler calls
+ ResourceHandleClient::didFail() which can delete the ResourceHandle.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::tlsErrorsChangedCallback): Protect the ResourceHandle
+ for the scope of the callback because
+ ResourceHandleClient::didFail() could delete the object.
+
+2016-02-03 Carlos Garcia Campos <[email protected]>
+
REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
https://bugs.webkit.org/show_bug.cgi?id=152797
Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (196060 => 196061)
--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2016-02-03 10:31:27 UTC (rev 196060)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2016-02-03 10:37:12 UTC (rev 196061)
@@ -338,11 +338,11 @@
static void tlsErrorsChangedCallback(SoupMessage* message, GParamSpec*, gpointer data)
{
- ResourceHandle* handle = static_cast<ResourceHandle*>(data);
+ RefPtr<ResourceHandle> handle = static_cast<ResourceHandle*>(data);
if (!handle || handle->cancelledOrClientless())
return;
- if (handleUnignoredTLSErrors(handle, message))
+ if (handleUnignoredTLSErrors(handle.get(), message))
handle->cancel();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
