Title: [200056] trunk
Revision
200056
Author
[email protected]
Date
2016-04-25 16:13:54 -0700 (Mon, 25 Apr 2016)

Log Message

Add port 4190 (managesieve) to port blacklist
https://bugs.webkit.org/show_bug.cgi?id=156986
<rdar://problem/9119470>

Reviewed by Daniel Bates.

Source/WebCore:

Tested by security/block-test.html.

* platform/URL.cpp:
(WebCore::portAllowed): Add 4190 to the port blacklist.

LayoutTests:

* platform/mac/security/block-test-expected.txt
* security/block-test-expected.txt:
* security/block-test.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (200055 => 200056)


--- trunk/LayoutTests/ChangeLog	2016-04-25 23:04:18 UTC (rev 200055)
+++ trunk/LayoutTests/ChangeLog	2016-04-25 23:13:54 UTC (rev 200056)
@@ -1,3 +1,15 @@
+2016-04-25  Brent Fulgham  <[email protected]>
+
+        Add port 4190 (managesieve) to port blacklist
+        https://bugs.webkit.org/show_bug.cgi?id=156986
+        <rdar://problem/9119470>
+
+        Reviewed by Daniel Bates.
+
+        * platform/mac/security/block-test-expected.txt
+        * security/block-test-expected.txt:
+        * security/block-test.html:
+
 2016-04-25  Ryan Haddad  <[email protected]>
 
         Rebaseline editing tests for ios-simulator-wk1

Modified: trunk/LayoutTests/platform/mac/security/block-test-expected.txt (200055 => 200056)


--- trunk/LayoutTests/platform/mac/security/block-test-expected.txt	2016-04-25 23:04:18 UTC (rev 200055)
+++ trunk/LayoutTests/platform/mac/security/block-test-expected.txt	2016-04-25 23:13:54 UTC (rev 200056)
@@ -115,6 +115,8 @@
 http://255.255.255.255:3659/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:3659/test.jpg">
 http://255.255.255.255:4045/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:4045/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
 http://255.255.255.255:4045/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:4045/test.jpg">
+http://255.255.255.255:4190/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:4190/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
+http://255.255.255.255:4190/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:4190/test.jpg">
 http://255.255.255.255:6000/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6000/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
 http://255.255.255.255:6000/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:6000/test.jpg">
 http://255.255.255.255:6665/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6665/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)

Modified: trunk/LayoutTests/security/block-test-expected.txt (200055 => 200056)


--- trunk/LayoutTests/security/block-test-expected.txt	2016-04-25 23:04:18 UTC (rev 200055)
+++ trunk/LayoutTests/security/block-test-expected.txt	2016-04-25 23:13:54 UTC (rev 200056)
@@ -115,6 +115,8 @@
 http://255.255.255.255:3659/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:3659/test.jpg">
 http://255.255.255.255:4045/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:4045/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
 http://255.255.255.255:4045/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:4045/test.jpg">
+http://255.255.255.255:4190/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:4190/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
+http://255.255.255.255:4190/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:4190/test.jpg">
 http://255.255.255.255:6000/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6000/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
 http://255.255.255.255:6000/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:6000/test.jpg">
 http://255.255.255.255:6665/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6665/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)

Modified: trunk/LayoutTests/security/block-test.html (200055 => 200056)


--- trunk/LayoutTests/security/block-test.html	2016-04-25 23:04:18 UTC (rev 200055)
+++ trunk/LayoutTests/security/block-test.html	2016-04-25 23:13:54 UTC (rev 200056)
@@ -6,7 +6,7 @@
       103, 104, 109, 110, 111, 113, 115, 117, 119, 123, 135, 139,
       143, 179, 389, 465, 512, 513, 514, 515, 526, 530, 531, 532,
       540, 556, 563, 587, 601, 636, 993, 995, 2049, 3659, 4045,
-      6000, 6665, 6666, 6667, 6668, 6669,
+      4190, 6000, 6665, 6666, 6667, 6668, 6669,
 
       // Port numbers that we consider to be invalid due to being out of range.
       Math.pow(2, 16) - 1, Math.pow(2, 16), Math.pow(2, 32) - 1, Math.pow(2, 32)];

Modified: trunk/Source/WebCore/ChangeLog (200055 => 200056)


--- trunk/Source/WebCore/ChangeLog	2016-04-25 23:04:18 UTC (rev 200055)
+++ trunk/Source/WebCore/ChangeLog	2016-04-25 23:13:54 UTC (rev 200056)
@@ -1,3 +1,16 @@
+2016-04-25  Brent Fulgham  <[email protected]>
+
+        Add port 4190 (managesieve) to port blacklist
+        https://bugs.webkit.org/show_bug.cgi?id=156986
+        <rdar://problem/9119470>
+
+        Reviewed by Daniel Bates.
+
+        Tested by security/block-test.html.
+
+        * platform/URL.cpp:
+        (WebCore::portAllowed): Add 4190 to the port blacklist.
+
 2016-04-25  Nan Wang  <[email protected]>
 
         AX: Crash at -[WebAccessibilityObjectWrapper accessibilityAttributeValue:] + 4391

Modified: trunk/Source/WebCore/platform/URL.cpp (200055 => 200056)


--- trunk/Source/WebCore/platform/URL.cpp	2016-04-25 23:04:18 UTC (rev 200055)
+++ trunk/Source/WebCore/platform/URL.cpp	2016-04-25 23:13:54 UTC (rev 200056)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2004, 2007, 2008, 2011, 2012, 2013, 2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2004, 2007, 2008, 2011, 2012, 2013, 2015-2016 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Research In Motion Limited. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -2101,6 +2101,7 @@
         2049, // NFS
         3659, // apple-sasl / PasswordServer [Apple addition]
         4045, // lockd
+        4190, // ManageSieve [Apple addition]
         6000, // X11
         6665, // Alternate IRC [Apple addition]
         6666, // Alternate IRC [Apple addition]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to