Title: [200057] trunk/Source/WebKit/mac
- Revision
- 200057
- Author
- [email protected]
- Date
- 2016-04-25 16:34:06 -0700 (Mon, 25 Apr 2016)
Log Message
WebEditorClient should properly write to m_rangeForCandidates
https://bugs.webkit.org/show_bug.cgi?id=157003
-and corresponding-
rdar://problem/25910418
Reviewed by Tim Horton.
Actually write to m_rangeForCandidates instead of declaring a local variable
of the same name. :-/
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::requestCandidatesForSelection):
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (200056 => 200057)
--- trunk/Source/WebKit/mac/ChangeLog 2016-04-25 23:13:54 UTC (rev 200056)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-04-25 23:34:06 UTC (rev 200057)
@@ -1,3 +1,17 @@
+2016-04-25 Beth Dakin <[email protected]>
+
+ WebEditorClient should properly write to m_rangeForCandidates
+ https://bugs.webkit.org/show_bug.cgi?id=157003
+ -and corresponding-
+ rdar://problem/25910418
+
+ Reviewed by Tim Horton.
+
+ Actually write to m_rangeForCandidates instead of declaring a local variable
+ of the same name. :-/
+ * WebCoreSupport/WebEditorClient.mm:
+ (WebEditorClient::requestCandidatesForSelection):
+
2016-04-23 Andy Estes <[email protected]>
Fix issues found by the clang static analyzer
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm (200056 => 200057)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm 2016-04-25 23:13:54 UTC (rev 200056)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm 2016-04-25 23:34:06 UTC (rev 200057)
@@ -1153,7 +1153,7 @@
int lengthToSelectionStart = TextIterator::rangeLength(makeRange(paragraphStart, selectionStart).get());
int lengthToSelectionEnd = TextIterator::rangeLength(makeRange(paragraphStart, selectionEnd).get());
- NSRange m_rangeForCandidates = NSMakeRange(lengthToSelectionStart, lengthToSelectionEnd - lengthToSelectionStart);
+ m_rangeForCandidates = NSMakeRange(lengthToSelectionStart, lengthToSelectionEnd - lengthToSelectionStart);
m_paragraphContextForCandidateRequest = plainText(makeRange(paragraphStart, paragraphEnd).get());
NSTextCheckingTypes checkingTypes = NSTextCheckingTypeSpelling | NSTextCheckingTypeReplacement | NSTextCheckingTypeCorrection;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
