I absolutely understand that there are ways to proactively find reviewers, and I'm *not* complaining about the time being taken (I understand the constraints that most of the webkit reviewers have been under the last few weeks with WWDC, etc). As you say, we can always ping people on IRC to find reviewers for bugfixes. I was more specifically wondering if there was something about this patch that made it not show up on the list Eric provided below. My concern is because the bugfix came from a google.com address, it might have been getting lumped in with the "oh, must be Yet Another Chromium Patch so I won't worry about it" list, which if true has troubling implications given that there are an increasing number of Googlers that are making contributions to WebKit that have nothing to do with Chromium.
-atw On Fri, Jun 19, 2009 at 10:51 AM, David Levin <[email protected]> wrote: > Drew, if you go to http://nightly.webkit.org/start/, then click "*Patches > awaiting Review <http://webkit.org/pending-review>".* > * > That is the list folks work off of, but it doesn't hurt to figure out the > appropriate person to review the patch (find out who has changed the file a > lot) and ping them in irc to see if they can get to it. > > Dave > > > * > On Fri, Jun 19, 2009 at 10:21 AM, Drew Wilson <[email protected]> wrote: > >> I note that this bug fix: >> https://bugs.webkit.org/show_bug.cgi?id=23721 >> >> ...was not on the list below, and has been waiting for some reviewer love >> for a couple of weeks now. Is it falling through the cracks somehow? >> >> -atw >> >> >> On Fri, Jun 19, 2009 at 4:18 AM, Andrei Popescu <[email protected]>wrote: >> >>> Hi, >>> >>> On Fri, Jun 19, 2009 at 3:03 AM, Eric Seidel<[email protected]> wrote: >>> > >>> > The other 24 remaining patches consist of 6 Gtk patches, 3 Chromium >>> > patches, and a bunch of huge new feature patches. >>> > >>> >>> No quite. The following two are rather small patches to common code >>> (appcache and database): >>> >>> https://bugs.webkit.org/show_bug.cgi?id=22700 >>> https://bugs.webkit.org/show_bug.cgi?id=25711 >>> >>> I think Alexey promised to look at them. >>> >>> Thanks, >>> Andrei >>> _______________________________________________ >>> webkit-dev mailing list >>> [email protected] >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>> >> >> >> _______________________________________________ >> webkit-dev mailing list >> [email protected] >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> >
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
