While having consistency in changelog descriptions is nice, I'm not sure we need to explicitly deal with the case of having multiple authors or multiple bugs for a change. Those are rare enough situations that it's fine for people to include that information however they want. Or, if you don't agree with me, we can at least make those a separate discussion. It would be nice if this discussion could focus on what goes in the default text of a changelog description.
The original goal here was to reduce the number of patches that get r-'ed for unnecessary changelog errors. Multiple authors rarely, if ever, results in an r-. Similarly, multiple bugs is rarely an issue for new contributors. Ojan On Thu, Jul 9, 2009 at 1:30 PM, Mark Rowe <mr...@apple.com> wrote: > > On 2009-07-09, at 08:02, Joe Mason wrote: > > Maciej Stachowiak wrote: >> >>> Now that my attention has been called to it, it's starting to bug me that >>> everyone formats their ChangeLog entries slightly differently. How about >>> this as the canonical format (with prepare-ChangeLog encouraging it)? >>> >> >> That reminds me: how do we format a patch with multiple authors? I've >> been doing this: >> >> 2009-07-08 Maciej Stachowiak <m...@apple.com> >>> Make prepare-ChangeLog less shouty >>> https://bugs.webkit.org/show_bug.cgi?id=27098 >>> >> > Authors: Maciej Stachowiak <m...@apple.com>, Joe Mason < >> joe.ma...@torchmobile.com> >> >>> Reviewed by Mark Rowe. >>> * Scripts/prepare-ChangeLog: >>> >> >> So, the main author (or whichever one is submitting the patch if that's >> unclear) in the header, then a separate "Authors" line above the Reviewer >> line with everyone who deserves credit. >> > > I've never seen this format used in WebKit patches. > > - Mark > > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
