On Wed, 2009-08-26 at 17:38 -0700, Geoffrey Garen wrote:
> [This question not necessarily just for Peter:]
>
> If we removed the discipline of reviewing ChangeLogs, and the tools
> that autogenerate a ChangeLog template and check for a ChangeLog entry
> without an "OOPs I didn't get this reviewed" message, what would we
> replace them with?
You can include the commit message to the patch nevertheless. That's
what git format-patch does, for instance. I am attaching an example.
See you,
--
Gustavo Noronha Silva <g...@gnome.org>
GNOME
>From 04a4fd6c2a0f59c990162fcbac6607d50240dc38 Mon Sep 17 00:00:00 2001
From: jmalo...@webkit.org <jmalo...@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri, 28 Aug 2009 15:12:29 +0000
Subject: [PATCH] 2009-08-28 Jan Michael Alonzo <jmalo...@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Add view source mode API
https://bugs.webkit.org/show_bug.cgi?id=28805
Implement setter and getter for "view source" mode.
* webkit/webkitwebview.cpp:
(webkit_web_view_set_view_source_mode):
(webkit_web_frame_get_view_source_mode):
* webkit/webkitwebview.h:
git-svn-id: http://svn.webkit.org/repository/webkit/tr...@47865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
WebKit/gtk/ChangeLog | 14 ++++++++++++
WebKit/gtk/webkit/webkitwebview.cpp | 38 +++++++++++++++++++++++++++++++++++
WebKit/gtk/webkit/webkitwebview.h | 7 ++++++
3 files changed, 59 insertions(+), 0 deletions(-)
diff --git a/WebKit/gtk/ChangeLog b/WebKit/gtk/ChangeLog
index 4d64cc8..da5a432 100644
--- a/WebKit/gtk/ChangeLog
+++ b/WebKit/gtk/ChangeLog
@@ -1,3 +1,17 @@
+2009-08-28 Jan Michael Alonzo <jmalo...@webkit.org>
+
+ Reviewed by Gustavo Noronha and Xan Lopez.
+
+ [Gtk] Add view source mode API
+ https://bugs.webkit.org/show_bug.cgi?id=28805
+
+ Implement setter and getter for "view source" mode.
+
+ * webkit/webkitwebview.cpp:
+ (webkit_web_view_set_view_source_mode):
+ (webkit_web_frame_get_view_source_mode):
+ * webkit/webkitwebview.h:
+
2009-08-26 Xan Lopez <xlo...@igalia.com>
Reviewed by Gustavo Noronha.
diff --git a/WebKit/gtk/webkit/webkitwebview.cpp b/WebKit/gtk/webkit/webkitwebview.cpp
index ae0b45f..8d0f08b 100644
--- a/WebKit/gtk/webkit/webkitwebview.cpp
+++ b/WebKit/gtk/webkit/webkitwebview.cpp
@@ -3733,3 +3733,41 @@ void webkit_web_view_redo(WebKitWebView* webView)
if (webkit_web_view_can_redo(webView))
g_signal_emit(webView, webkit_web_view_signals[REDO], 0);
}
+
+
+/**
+ * webkit_web_view_set_view_source_mode:
+ * @web_view: a #WebKitWebView
+ * @view_source_mode: the mode to turn on or off view source mode
+ *
+ * Set whether the view should be in view source mode. Setting this mode to
+ * %TRUE before loading a URI will display the source of the web page in a
+ * nice and readable format.
+ *
+ * Since: 1.1.14
+ */
+void webkit_web_view_set_view_source_mode (WebKitWebView* webView, gboolean mode)
+{
+ g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
+
+ if (Frame* mainFrame = core(webView)->mainFrame())
+ mainFrame->setInViewSourceMode(mode);
+}
+
+/**
+ * webkit_web_view_get_view_source_mode:
+ * @web_view: a #WebKitWebView
+ *
+ * Return value: %TRUE if @web_view is in view source mode, %FALSE otherwise.
+ *
+ * Since: 1.1.14
+ */
+gboolean webkit_web_view_get_view_source_mode (WebKitWebView* webView)
+{
+ g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), FALSE);
+
+ if (Frame* mainFrame = core(webView)->mainFrame())
+ return mainFrame->inViewSourceMode();
+
+ return FALSE;
+}
diff --git a/WebKit/gtk/webkit/webkitwebview.h b/WebKit/gtk/webkit/webkitwebview.h
index 42736dc..968b74e 100644
--- a/WebKit/gtk/webkit/webkitwebview.h
+++ b/WebKit/gtk/webkit/webkitwebview.h
@@ -356,6 +356,13 @@ webkit_web_view_redo (WebKitWebView *webView);
WEBKIT_API gboolean
webkit_web_view_can_redo (WebKitWebView *webView);
+WEBKIT_API void
+webkit_web_view_set_view_source_mode (WebKitWebView *web_view,
+ gboolean view_source_mode);
+
+WEBKIT_API gboolean
+webkit_web_view_get_view_source_mode (WebKitWebView *web_view);
+
G_END_DECLS
#endif
--
1.6.3.3
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
