The only time I've ever had an issue with committing is when I forgot to add the file myself. The bot uses the same scripts that committers do. I think it'd be worth your time to become comfortable with them. If nothing else, so you can land fixes for when you break the build. It also frees up the queue for those who need it. I'd take another shot at landing yourself if I were you.
On Thu, Feb 25, 2010 at 3:29 AM, Dan Bernstein <m...@apple.com> wrote: > > On Feb 24, 2010, at 3:50 PM, Eric Seidel wrote: > > > I find http://build.webkit.org/console more useful. > > > > In this case, looks like mitz's patch changed the test: > > http://trac.webkit.org/changeset/55203 > > Sorry about the inconvenience. I will try to fix this shortly. > > > > > I'm glad to see more folks are watching the bots! > > > > -eric > > > > On Wed, Feb 24, 2010 at 3:48 PM, David Levin <le...@chromium.org> wrote: > >> 1. It looks like you are a committer, so you don't need to wait for the > >> commit queue to do this for you :) > >> 2. But it still would be good to have this fixed. If you'd like to help > move > >> this along, you can go to http://build.webkit.org/waterfall and find > which > >> patch caused the test to start failing. Then ping the relevant person. > >> > >> On Wed, Feb 24, 2010 at 3:41 PM, Kenneth Russell <k...@google.com> > wrote: > >>> > >>> On Wed, Feb 24, 2010 at 12:02 PM, Alexey Proskuryakov <a...@webkit.org> > >>> wrote: > >>>> > >>>> On 24.02.2010, at 11:47, David Levin wrote: > >>>> > >>>> Actually, it doesn't appear to be do to recent changes in this > >>>> area. They > >>>> started failing after r55177 > >>>> (http://build.webkit.org/waterfall?last_time=1266975298), but that > >>>> change is > >>>> unrelated to these test as far as I can tell. > >>>> > >>>> It looks unrelated, but it somehow broke these editing tests > >>>> nonetheless. > >>>> I'm investigating now. > >>> > >>> Thanks. Our patch (from https://bugs.webkit.org/show_bug.cgi?id=34459) > >>> was about to be landed by the bot when the tree went red again. The > >>> test now failing is: > >>> > >>> fast/dom/prototype-inheritance-2.html -> failed > >>> > >>> Could someone please look? > >>> > >>> Thanks, > >>> > >>> -Ken > >> > >> > >> _______________________________________________ > >> webkit-dev mailing list > >> webkit-dev@lists.webkit.org > >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >> > >> > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
