I agree with Jeremy and David. If you are a committer you should try to land patches on your own when you can. I mainly think this because it lets svn/git blame work as intended instead of always blaming who ran the bot. Maybe we should have a commit-...@webkit.org user?
On Feb 25, 2010, at 5:41 AM, Eric Seidel wrote: > On Thu, Feb 25, 2010 at 5:26 AM, Jeremy Orlow <jor...@chromium.org> wrote: >> It also frees up the queue for those who need it. > > A common misconception, but looking at the logs the commit-queue looks > to be no where near capacity. I believe it could commit every change > done to WebKit in a day and still not be near capacity. :) > > The only thing that prevents the commit-queue from cycling regularly > is the bots breaking (this includes flakey tests). :( > > -eric > >> >> On Thu, Feb 25, 2010 at 1:17 AM, Kenneth Russell <k...@google.com> wrote: >>> >>> On Wed, Feb 24, 2010 at 3:48 PM, David Levin <le...@chromium.org> wrote: >>>> 1. It looks like you are a committer, so you don't need to wait for the >>>> commit queue to do this for you :) >>> >>> Understood -- but I prefer to use the bots where possible. I've seen >>> multiple instances where the commit scripts failed to add new files >>> for some reason, but the bots have always been 100% reliable. >>> >>> -Ken >>> >>>> 2. But it still would be good to have this fixed. If you'd like to help >>>> move >>>> this along, you can go to http://build.webkit.org/waterfall and find >>>> which >>>> patch caused the test to start failing. Then ping the relevant person. >>>> >>>> On Wed, Feb 24, 2010 at 3:41 PM, Kenneth Russell <k...@google.com> wrote: >>>>> >>>>> On Wed, Feb 24, 2010 at 12:02 PM, Alexey Proskuryakov <a...@webkit.org> >>>>> wrote: >>>>>> >>>>>> On 24.02.2010, at 11:47, David Levin wrote: >>>>>> >>>>>> Actually, it doesn't appear to be do to recent changes in this >>>>>> area. They >>>>>> started failing after r55177 >>>>>> (http://build.webkit.org/waterfall?last_time=1266975298), but that >>>>>> change is >>>>>> unrelated to these test as far as I can tell. >>>>>> >>>>>> It looks unrelated, but it somehow broke these editing tests >>>>>> nonetheless. >>>>>> I'm investigating now. >>>>> >>>>> Thanks. Our patch (from https://bugs.webkit.org/show_bug.cgi?id=34459) >>>>> was about to be landed by the bot when the tree went red again. The >>>>> test now failing is: >>>>> >>>>> fast/dom/prototype-inheritance-2.html -> failed >>>>> >>>>> Could someone please look? >>>>> >>>>> Thanks, >>>>> >>>>> -Ken >>>> >>>> >>> _______________________________________________ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> >> _______________________________________________ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev