On Apr 14, 2010, at 2:13 PM, Eric Seidel wrote:

Anders brought to my attention this afternoon that webkit-patch
currently does all SVN operations from the root directory instead of
being current-directory aware.  That behavior matches how Git
operates, but does not need to be how webkit-patch operates.

Question: Do SVN users wish to have webkit-patch be
current-working-directory aware?

Meaning:
"upload" will only prepare-ChangeLog for the current directory and
upload an svn diff under the current directory.
"land" will only land the current subdirectory.

The propose change will make webkit-patch inconsistent between VCS
tools, but consistent with the users choice of SVN vs. Git.  Is this
SVN users desired behavior?

As an SVN user, I would prefer if webkit-patch operations that create a patch worked on the current directory or below, and failed if you are in a directory that does not contain a ChangeLog. I sometimes have independently landable patches in JavaScriptCore an in WebCore +LayoutTests and it is handy to be able to use webkit-patch without having to locally revert one of the two patches.

Regards,
Maciej

_______________________________________________
webkit-dev mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Reply via email to