On Apr 29, 2010, at 1:05 PM, Adam Barth wrote:
On Thu, Apr 29, 2010 at 12:43 PM, Maciej Stachowiak <m...@apple.com>
wrote:
It seems to me a better model would be to regenerate the bindings
test file
automatically as part of the build. Then the changes can still be
reviewed
by you, or as part of a diff, but there would be no extra manual
steps
involved. And people making behaviorally transparent changes to
codegen
output would perhaps feel a little less burdened.
That sounds like a good improvement. I think it would be fine to
regenerate the output as part of the build. However, I think we
should still preserve the ability to run the script along it "test"
mode because that's about three orders of magnitude faster than
performing a build after touching CodeGeneratorJS.
Alexey (or others who don't like the new tests), do you think this
change would address your concerns?
On Apr 29, 2010, at 1:05 PM, Adam Barth wrote:
What I hear from this conversation is the following:
1) A bunch of people who've used the tool saying that they've found
it useful.
2) A bunch of people who haven't used the tool suggesting
improvements.
This tool impacts the handful of people who work on
CodeGeneratorJS.pm. Everyone else in the project can safely ignore
it. I'm all for improvements, and I invite anyone interested to
either improve the tool or write a new tool that does the job better.
If everyone has to use the tool for the tool to be useful, then
ideally we want a system where the people who change the bindings
frequently mostly buy into. Here is the list of people with more than
5 all-time commits in the WebCore/bindings/scripts directory. Ideally
I'd like to hear from more of these what they think would be helpful
and not burdensome.
59 wei...@apple.com
46 e...@webkit.org
35 da...@apple.com
32 jap...@chromium.org
29 oli...@apple.com
26 gga...@apple.com
26 dglaz...@chromium.org
16 aba...@webkit.org
14 zimmerm...@webkit.org
12 a...@webkit.org
10 aro...@apple.com
8 le...@chromium.org
7 m...@apple.com
7 da...@chromium.org
6 timo...@apple.com
6 s...@chromium.org
6 jia...@chromium.org
6 ddkil...@apple.com
6 cwzwar...@webkit.org
Here is the command anyone can run to see the full list (assuming you
have an SVN checkout):
$ svn log WebCore/bindings/scripts | grep '|.*@' | sed -e 's/^[^|]* |//
g; s/ | .*$//g;' | sort | uniq -c | sort -rn
The long tail of people who have made only a few bindings changes is
rather large, so I suspect this tool affects more than a handful
people, if it becomes a mandatory part of the process.
Regards,
Maciej
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
