On Wed, Aug 11, 2010 at 10:29 PM, Cedric Vivier <[email protected]> wrote:
> On Thu, Aug 12, 2010 at 13:26, Sam Weinig <[email protected]> wrote: > >> For this specific case, it seems like you could easily check for a null >> WebGLProgram* in WebGLRenderingContext::useProgram and set the >> ExceptionCode. > > > Nope, null is a valid argument, it bounds to the initial program, which > means nothing will be drawn with WebGL. > Certainly not the expected behavior when one pass the wrong type to the > argument like Zhenyao pointed out, therefore throwing TypeError really makes > sense here (and elsewhere with WebGL API). > > Ok, in that case, it seems like you need to do it in the bindings for this. I would prefer not making a sweeping change at this time, and instead keeping the changes just to places where the extra checking is necessary due to ambiguity (as in this useProgram case). -Sam
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
