On Sat, Sep 25, 2010 at 3:02 PM, David Hyatt <[email protected]> wrote:
> On Sep 24, 2010, at 6:56 PM, Eric Mader wrote: > > This method makes several assumptions that I'm not 100% sure are always > safe: > * That a RenderRuby object holds only 1 RenderRubyRun object. > > > I believe you can have multiple RenderRubyRuns inside a single RenderRuby. > > > http://www.whatwg.org/specs/web-apps/current-work/multipage/text-level-semantics.html#the-ruby-element > > "The ruby element allows one or more spans of phrasing content to be marked > with ruby annotations." > Yes - after the change for https://bugs.webkit.org/show_bug.cgi?id=41040, a ruby run will basically contain: [:before-generated content]? [RenderRubyRun]* [:after-generated content]? Where RenderRubyRun is an inline-block element with 1 RenderRubyBase and (currently) 0-1 RenderRubyTexts - the latter may change to 0-n at some point. Thinking this further, I also believe that once you implement ruby overhang for the edges of the <ruby> element it will really look strange unless you also implement overhang and offsets between ruby runs within the same <ruby> element - i.e., implement Jukugo-ruby. This then has implications on the line-breaking code within a single ruby. Finally, as yet another corner case that I forgot in my last mail: as implied above note that you also have to consider the :before/:after-generated content for overhang. Incidentally, you'll also have to consider generated content for item 4) of your initial list (over/under-lines on ruby). Cheers, - Roland
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
