On Fri, Oct 8, 2010 at 3:29 PM, Maciej Stachowiak <m...@apple.com> wrote:
> > On Oct 8, 2010, at 3:05 PM, Jian Li wrote: > > Sounds good. I will add the File API feature guard to it and still keep > those files under html/canvas. > > > Another possibility is to have an ArrayBuffer feature guard and ensure that > it is on if at least one of the features depending on it is on. > > This also sounds good. Personally I prefer appending File API feature guard since it is simpler. When array buffer is used in XHR, we can then simply remove all the feature guards. Otherwise, we will have to update all the config files to add a new feature guard. > - Maciej > > > On Fri, Oct 8, 2010 at 2:55 PM, Darin Adler <da...@apple.com> wrote: > >> On Oct 8, 2010, at 2:46 PM, Jian Li wrote: >> >> > Currently all these typed array supports are put under 3D_CANVAS feature >> guard. Since they're going to be widely used in other areas, like File API >> and XHR, should we remove the conditional guard 3D_CANVAS from all the >> related files? >> >> I suggest we keep the guard up to date. These arrays should be compiled in >> if any of the features that use them are compiled in. Once they are used in >> XMLHttpRequest, then they won’t need feature guards at all, but I believe >> the File API may still be under a feature guard. >> >> -- Darin >> >> > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
