I got swamped with other work and haven't started it. It would be great if you would pick it up. I'll be happy to do code reviews.
-Ken On Sun, Nov 14, 2010 at 6:49 PM, Jian Li <jia...@chromium.org> wrote: > Kenneth, if you have not started working on adding DataView support, I can > take this to make it work. How do you think? Thanks. > > On Wed, Oct 13, 2010 at 8:37 AM, Jian Li <jia...@chromium.org> wrote: >> >> >> On Tue, Oct 12, 2010 at 2:17 PM, Kenneth Russell <k...@google.com> wrote: >>> >>> On Fri, Oct 8, 2010 at 2:46 PM, Jian Li <jia...@chromium.org> wrote: >>> > Hi, >>> > I am looking into hooking up ArrayBuffer support in FileReader and >>> > BlobBuilder. It seems that most of the typed array types (ArrayBuffer, >>> > ArrayBufferView, Uint8Array, and etc) have already been implemented in >>> > WebKit, except TypedArray.get() and DataView. >>> >>> Since most of the other questions have been answered: >>> >>> https://bugs.webkit.org/show_bug.cgi?id=46541 covers implementation of >>> DataView. I will try to take care of this in the next week or two. Let >>> me know if you need it before I've gotten to it. >> >> I do not need it in implementing ArrayBuffer support in FileReader and >> BlobBuilder. Currently I just instantiate a subinstance of ArrayBufferView >> to get the data for testing purpose. But it would be better if we can have >> DataView implemented in order to provide a way for the user to >> read heterogeneous data. >>> >>> > Currently all these typed array supports are put under 3D_CANVAS >>> > feature >>> > guard. Since they're going to be widely used in other areas, like File >>> > API >>> > and XHR, should we remove the conditional guard 3D_CANVAS from all the >>> > related files? Should we also move these files out of html\canvas, say >>> > into >>> > html\ or html\typearrays? >>> > In addition, get() is not implemented for typed array views. Should we >>> > add >>> > it? >>> >>> Both the setter and getter in the Web IDL are defined as omittable, >>> which means that in the ECMAScript binding the indexing operator "[]" >>> is used for both getting and setting values. Both are fully >>> implemented in JSC and V8. At the C++ level, the "item" and "set" >>> methods (see IntegralTypedArrayBase and Float32Array for example) are >>> used in certain cases to implement the getter and setter. >> >> I noticed that and already used it in my test scripts. Thanks for pointing >> it out. >>> >>> -Ken >>> >>> > Jian >>> > >>> > _______________________________________________ >>> > webkit-dev mailing list >>> > webkit-dev@lists.webkit.org >>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>> > >>> > >> > > _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
