On Dec 8, 2010, at 2:03 PM, Darin Adler wrote:
> On Dec 8, 2010, at 1:23 PM, Simon Fraser wrote:
>
>> On Dec 8, 2010, at 12:57 PM, Darin Adler wrote:
>>
>>> On Dec 8, 2010, at 12:13 PM, Peter Kasting wrote:
>>>
>>>> We could greatly decrease the number of these baselines by following a
>>>> simple rule: don't display text unless you need to.
>>>
>>> Seems like a good idea. I’m worried a bit, though, that if we can’t use any
>>> text in them at all, the tests are then not at all self explanatory. You
>>> have to be an expert on the test to understand what it’s testing and what
>>> success and failure look like.
>>
>> Do HTML comments fulfill this?
>
> Peter, Simon,
>
> You both have convinced me that HTML comments could be fine for explaining
> what a test is testing. Maybe we could come up with a format that makes it
> likely we’ll spot those comments.
>
> The success vs. failure aspects can probably be addressed by the “see no red”
> and other such things.
Maybe we could come up with a way to print the explanation in the browser only,
and not in DumpRenderTree. A simple convention could be:
if (!window.layoutTestController)
document.write("Explanation of what the test is testing goes here.");
This is slightly more convenient than an HTML comment when you open a test in
the browser to see what's going on.
Regards,
Maciej
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
