Yes, reading the checksum is the same speed as before.  We write the png
comment at the beginning of the file and only scan the first 2k of the file
for the checksum.  I also tried converting about 200 tests to use embedded
checksums and found no speed difference.

I've already updated new-run-webkit-tests, but plan on updating
old-run-webkit-tests as well since it's a small amount of code (only about
20 lines of python, I imagine the amount of perl will be similar).

On Tue, Apr 5, 2011 at 3:55 PM, Darin Adler <da...@apple.com> wrote:

> Sounds like a great idea, as long as reading the checksum is still fast.
>
> I couldn’t tell when you mentioned run-webkit-tests in your steps what your
> specific plans are for old-run-webkit-tests and new-run-webkit-tests.
>
>    -- Darin
>
>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Reply via email to