I think more important issue to consider is should WebKit unit-tests (TestWebKitAPI) live under Tools. Unit-tests evolve with the product and an organic part of it - it doesn't feel that they constitute a "tool".
Three possible locations come to mind: - ./Tests - separate top-level directory, sibling to Source and LayoutTests - ./Source/Test - separate directory, but under Source to emphasize that tests are part of the source code - Scattered around by the files that tests test, as David suggests. In terms of gtest directory placement, I think it is nice to have all third-party libraries live in the same place. What do people think? Kind regards, Dmitry On Thu, May 12, 2011 at 9:38 AM, David Levin <[email protected]> wrote: > It sounds like you have a helpful mental mapping for what belongs in each > directory that we haven't written anywhere. Perhaps you could write it down > and send it to webkit-dev so that we can make it a common model. > > It feels like a related topic is why are the unit tests under Tools as > opposed to being by the files that they test. Being by the files they tests > would make them easier to find and change as needed. (For an example of > where this is done, see > http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common where > there is file.py and file_unittest.py) > > dave > > > On Thu, May 12, 2011 at 8:36 AM, Dan Bernstein <[email protected]> wrote: > >> Is gtest required to build any of the WebKit ports? If not, can it be >> moved out of Source and into Tools? >> >> Thanks, >> —Dan >> _______________________________________________ >> webkit-dev mailing list >> [email protected] >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > > > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
