在 2011年10月7日 下午11:56，Fady Samuel <[email protected]>写道：
> Hi all, > > I've just uploaded a patch https://bugs.webkit.org/show_bug.cgi?id=69631 > that's > intended to make PopupMenuClient testable. > > On certain Chromium platforms, the position of the <select> element's popup > is incorrect if the page's scale factor is not 1.0. > > The fix to the problem is simple, see > https://bugs.webkit.org/show_bug.cgi?id=66062 , but since popups are > external to WebKit on most platforms, this is difficult to test. > > The patch above in bug 69631 attempts to addresses this, albeit in a less > than ideal way. I'm not sure what's the best way to test this, but this is > my stab at it. > Even if the popup is external, the render dump (not text dump) still contains layout information. You can write a layout test with page's scale factor not 1.0, then generate the expectation results among WebKit ports. Do you think Is that enough for your test? > > I'd really appreciate any comments or suggestions you can provide on my > patch for bug 69631. > > Thanks, > > Fady > > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > -- Best regards, Johnny(Jianning) Ding | Software Engineer | [email protected] | (86)189-1186-0082
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
