*ping* I'd love to get some feedback on https://bugs.webkit.org/show_bug.cgi?id=69631. :-)
Thanks, Fady On Mon, Oct 10, 2011 at 5:27 PM, Fady Samuel <[email protected]> wrote: > Please review then? :-) > > Fady > > On Mon, Oct 10, 2011 at 9:11 PM, Darin Adler <[email protected]> wrote: > > On Oct 10, 2011, at 7:57 AM, Fady Samuel wrote: > > > >> My solution in 69631 is to expose the bounding box rect through the > PopupMenuClient interface and make it testable through window.internals. > I've also included a layout test to show how one would test this. Right now > the test fails, but once 66062 is applied the test will pass. > >> > >> Is this a reasonable approach? > > > > This seems OK to me. > > > > -- Darin > > > > >
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
