On Thu, May 17, 2012 at 12:47 PM, Ryosuke Niwa <[email protected]> wrote: > On Thu, May 17, 2012 at 12:36 PM, Dirk Pranke <[email protected]> wrote: >> >> On Thu, May 17, 2012 at 4:30 AM, Ojan Vafai <[email protected]> wrote: >> > -Make everything but the test name case-insensitive. >> >> I don't think I like this; it could lead to a lot of arbitrarily >> different formatting in the file, making things harder to read. > > > Modifiers and expectations are already case-insensitive as far as I read the > code yesterday. >
It may be that it's legal to mix the case, but no one does it. >> I think we'd probably find ourselves (re-)converging on some convention >> pretty quickly. I personally find all uppercase fairly easy to read in >> this case since it distinguishes the modifiers from the test name. > > > I think this problem will disappear once we place modifiers and expectations > on the same side > because then there is exactly one place those tokens could appear. There is > no need to scan > through a line then. > It's possible. As I said, having some other clear delimiter would help. >> >> If we have some other clear delimiter this would probably be less >> important, in which case all lower case would be fine as well. Initial caps >> seems less good to me. > > > I find either all-lowercase or all-caps to be much harder to read than > capitalized words. They look like a blob of letters to me. We might have to agree to disagree here, then, but that's fine. If there was a clear consensus that one style or another is better, we should go with that. > Also, I don't > think we use all-caps name anywhere else in WebKit so it's inconsistent with > the convention we use elsewhere. > I don't think this particularly matters. We should design a format based on what is most useful in this context. -- Dirk _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
