On Wed, Aug 8, 2012 at 9:54 PM, Eric U <[email protected]> wrote: > On Wed, Aug 8, 2012 at 11:43 AM, Alexey Proskuryakov <[email protected]> > wrote: > > I can see some downsides to emptying the cache before each test: > > > > - we won't be getting any test coverage for cache behavior when it hits > > non-trivial size; > > Then let's add a cache test explicitly for this. Otherwise we just > have to hope it gets tested accidentally along the way. >
Cache has subtle interactions with other things being tested (->flakiness). More explicit cache tests would be nice but we can't hope the replicate all the accidental testing we now get. We are going to lose a large chunk of existing test coverage if we do this. antti > > > - this may well make tests measurably slower; > > > > - this will be yet another cause of subtle difference between platforms, > as > > some will undoubtedly have this unimplemented for a long time. > > Both good points, but probably worth it, given the reliability > improvement in the tests IMO. > > Eric > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo/webkit-dev >
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo/webkit-dev
