On Tue, May 21, 2013 at 10:23 AM, Darin Adler <da...@apple.com> wrote:
> On this regard, I think it would be specially interesting to hear > the opinion of the people involved in the bug that tracked this addition: > https://bugs.webkit.org/show_bug.cgi?id=115567 > > > Sure. Jessie and Ben, when you have a chance could one or both of you > comment? > For me that rule was more about asking people to think twice and add the proper abstraction when possible. We do not want style checker warnings, which becomes a motivation for creating better abstractions. For example, recently a second implementation of some of DOMFileSystemBase was added for blackberry (most if it is an exact copy of the common code). With a style checker warning, the author would have had to justify this kind of decision (and hopefully fix the code instead). Benjamin
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
