Hi Ali,

I think it is valuable to upload a patch containing source code changes
with the new/modified WPT tests covering these changes.
I would recommend to do the GitHub submission in parallel and add a
reference to the GitHub PR in WebKit bugzilla.
Ideally, the GitHub PR would be merged before the WebKit patch is committed.
    y

Le mar. 11 juil. 2017 à 16:14, Ali Juma <aj...@chromium.org> a écrit :

> Hi all,
>
> Just wanted to check what the current recommended approach is for new WPT
> tests. Is it now ok to add new tests directly in
> LayoutTests/imported/w3c/web-platform-tests and then upstream them, or
> should tests still be added elsewhere first (in LayoutTests/http/wpt?),
> upstreamed, and then moved into LayoutTests/imported/w3c/web-
> platform-tests?
>
> Thanks,
> Ali
>
> On Sun, May 21, 2017 at 11:14 PM youenn fablet <youe...@gmail.com> wrote:
>
>> Filed https://bugs.webkit.org/show_bug.cgi?id=172435 about that
>>
>>
>> Le dim. 21 mai 2017 à 00:40, Maciej Stachowiak <m...@apple.com> a écrit :
>>
>>> On May 18, 2017, at 2:08 PM, Philip Jägenstedt <foo...@google.com>
>>> wrote:
>>>
>>> On Tue, May 16, 2017 at 5:38 PM youenn fablet <youe...@gmail.com> wrote:
>>>
>>>>
>>>> There was a suggestion that LayoutTests/imported/w3c/web-platform-tests
>>>> be moved to a shorter path like LayoutTests/web-platform-tests. That would
>>>> also make it clear that this folder is not only about one-way-sync.
>>>>
>>>
>>> In Blink we renamed it to LayoutTests/external/wpt/ to avoid the "read
>>> only" implications of the old name.
>>>
>>>
>>> If we go forward with two-way sync, I think this is a good name.
>>>
>>> Regards,
>>> Maciej
>>>
>>>
>>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>>
>>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Reply via email to