"target.inline-breakpoint-strategy always” is also the workaround suggested in the bugs Simon cited.
Note that this setting is also necessary to fix a bunch of bugs with breakpoints in headers. Geoff > On Aug 29, 2017, at 11:03 PM, Rik Cabanier <caban...@gmail.com> wrote: > > > > On Tue, Aug 29, 2017 at 8:48 PM, Simon Fraser <simon.fra...@apple.com > <mailto:simon.fra...@apple.com>> wrote: > > On Aug 28, 2017, at 9:46 PM, Geoffrey Garen <gga...@apple.com > > <mailto:gga...@apple.com>> wrote: > > > >> The line numbers and filenames will be total nonsense if we just > >> concatenate multiple source files together. But that's very easy to fix if > >> the script that concatenates the sources also adds a #line statement > >> between "files" to change the filename and reset the line number to 1. See > >> https://gcc.gnu.org/onlinedocs/cpp/Line-Control.html > >> <https://gcc.gnu.org/onlinedocs/cpp/Line-Control.html> (I suspect it will > >> work just fine for Clang as well). > > > > Our plan is to use #include. That has worked in the past. > > This should be tested before proceeding with the unified build plan. This has > certainly not always worked in the past (for Apple folks, see > rdar://problem/16751849 and rdar://problem/16829492, which is still open). > > Non-working breakpoints would be a show-stopper for many. > > Mozilla has been concatenating source files for a number of years. I don't > remember that they had to treat static specially but you did have to > configure XCode so you could set the breakpoints. > > See https://dxr.mozilla.org/mozilla-central/source/.lldbinit#17 > <https://dxr.mozilla.org/mozilla-central/source/.lldbinit#17> > >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
