In JSC EWS bots. For the other Debug EWS bots, (Like, WebCore Debug builds), I have no strong opinion.
-Yusuke > On Jun 17, 2020, at 6:07 PM, Yusuke Suzuki <ysuz...@apple.com> wrote: > > For EWS, we are running Release build right now. So in terms of stack traces, > nothing is changed. > > -Yusuke > >> On Jun 17, 2020, at 5:21 PM, Alexey Proskuryakov <a...@webkit.org >> <mailto:a...@webkit.org>> wrote: >> >> >> I frequently find it critically useful to see stack traces from debug >> builds, because of no inlining. So I don't think that we should do this. A >> local build does not help when the issue is not readily reproducible. >> >> - Alexey >> >> >>> 17 июня 2020 г., в 1:36 PM, Mark Lam <mark....@apple.com >>> <mailto:mark....@apple.com>> написал(а): >>> >>> Hi folks, >>> >>> We're planning to switch the JSC EWS bot and build.webkit.org >>> <http://build.webkit.org/> Debug build and test bots to building with the >>> following set first: >>> ./Tools/Scripts/set-webkit-configuration --force-opt=O3 >>> >>> This means the Debug builds will be built with optimization level forced to >>> O3. >>> >>> Why are we doing this? >>> 1. So that the JSC EWS will start catching ASSERT failures. >>> 2. JSC stress test Debug bots have been timing out and not running tests at >>> all. Hopefully, this change will fix this issue. >>> 3. Tests will run to completion faster and we’ll catch regressions sooner. >>> >>> The downside: crash stack traces will be like Release build stack traces. >>> But I don’t think we should let this deter us. It’s not like there’s no >>> stack information. And just as we do with debugging Release build test >>> failures, we can always do a Debug build locally to do our debugging. >>> >>> We would like to apply this change to all Debug build and test bots, not >>> just the JSC ones. Does anyone strongly object to this change? >>> >>> Thanks. >>> >>> Cheers, >>> Mark >>> >>> _______________________________________________ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org> >>> https://lists.webkit.org/mailman/listinfo/webkit-dev >>> <https://lists.webkit.org/mailman/listinfo/webkit-dev> >> >> >> _______________________________________________ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org> >> https://lists.webkit.org/mailman/listinfo/webkit-dev > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
