I also object to losing good stack traces for crashes on Debug bots. Also, I don't think Debug bots should build something different from what I build at my desk.
Simon > On Jun 17, 2020, at 1:36 PM, Mark Lam <mark....@apple.com> wrote: > > Hi folks, > > We're planning to switch the JSC EWS bot and build.webkit.org > <http://build.webkit.org/> Debug build and test bots to building with the > following set first: > ./Tools/Scripts/set-webkit-configuration --force-opt=O3 > > This means the Debug builds will be built with optimization level forced to > O3. > > Why are we doing this? > 1. So that the JSC EWS will start catching ASSERT failures. > 2. JSC stress test Debug bots have been timing out and not running tests at > all. Hopefully, this change will fix this issue. > 3. Tests will run to completion faster and we’ll catch regressions sooner. > > The downside: crash stack traces will be like Release build stack traces. > But I don’t think we should let this deter us. It’s not like there’s no > stack information. And just as we do with debugging Release build test > failures, we can always do a Debug build locally to do our debugging. > > We would like to apply this change to all Debug build and test bots, not just > the JSC ones. Does anyone strongly object to this change? > > Thanks. > > Cheers, > Mark > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
