I think it is still quite useful to fix non-unified builds. Otherwise adding a file usually involves many unrelated build fixes.
> On Jul 14, 2020, at 5:25 PM, Fujii Hironori <fujii.hiron...@gmail.com> wrote: > > > > On Wed, Jul 15, 2020 at 6:32 AM Sam Weinig <wei...@apple.com > <mailto:wei...@apple.com>> wrote: > While I don’t want to take away from what Darin is saying here about correct > usage of forward declaration and <wtf/Forward.h>, I’d like to understand why > we have two different compilation models supported in WebKit. Is there a > reason both need to be supported? Can we remove one? > > > I also want to know that. Does anyone still need non-unified builds? > > I introduced other unnecessary header inclusion, and Darin asked me to fix it. > https://bugs.webkit.org/show_bug.cgi?id=214204#c25 > <https://bugs.webkit.org/show_bug.cgi?id=214204#c25>Reducing header > inclusion can easily cause build breakages for non-unified builds. > So, I fixed non-unified build breakage in r264332 and r264333 as the > preparation for that. > Non-unified builds was more broken than I expected. Does anyone still need it? > Should we maintain non-unified builds until C++20 modules will nullify > unified builds? > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
