On Thu, Jul 16, 2020 at 4:14 pm, Darin Adler <da...@apple.com> wrote:
Let’s stop doing it that way. Just compile the files and have #if inside the file.

I removed all conditional source files from the Xcode build system. Let's do the same for the CMake build system.

— Darin

I agree we should do this. We've never been consistent between whether we guard files at the build system level or inside the files themselves. But with unified builds, the advantage of putting the guards inside the files is clear: we would ensure that the set of files compiled is always the same for a given port regardless of which options are used.

I wouldn't use that as a reason to drop non-unified builds, though. E.g. Yusuke's argument regarding compile_commands.json seems pretty compelling.

webkit-dev mailing list

Reply via email to