On Thu, Oct 21, 2010 at 12:34:28PM +0200, Tor Arne Vestbø wrote: > On 20.10.10 22.01, Ademar de Souza Reis Jr. wrote: > >Hi there. > > > >from http://trac.webkit.org/wiki/QtWebKitContrib: > >"Effective immediately all commits to QtWebKit should use the > >WebKit coding style for all files in the project. That includes > >qwebview(.h|cpp), qwebpage(.h|.cpp) and all others. Repeat: the > >Qt style should not be used. Thank you." > > > >I'm about to submit a patch changing check-webkit-style to > >enforce webkit coding style on Qt files. Since that is going to > >affect everybody, I just wanted to confirm you're all happy with > >such a change. :-) > > Wait, what? Who added that comment, and based on what discussion? > And what exactly does it mean? >
Hi. If the trac diff is right, it was added by Adam <[email protected]> 16 months ago: http://trac.webkit.org/wiki/QtWebKitContrib?action=diff&version=40&old_version=39 I was not participating of QtWebKit back then, I assumed this was discussed already. Yesterday I asked it on #qtwebkit and Kenneth confirmed it, so I assumed it was the rule. Anyway, looks like bringing this to the mailing list instead of submitting a patch was the right thing to do. :-) Cheers, - Ademar -- Ademar de Souza Reis Jr. OpenBossa Labs - Instituto Nokia de Tecnologia (INdT) ^[:wq! _______________________________________________ webkit-qt mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt
