On 01/17/2011 04:14 PM, ext Konstantin Tokarev wrote:
14.01.2011, 21:38, "Benjamin Poulain"<[email protected]>:
On 01/14/2011 07:30 PM, ext Konstantin Tokarev wrote:

  Long term QtWebKit will depends on QtScript for the bridge. To avoid
  inconsistencies and regressions, I think it would be more reasonable to
  guard the functions of the bridge with #ifndef QT_NO_SCRIPT.
  Do you mean it's OK to disable whole class QtInstance? (AFAIU, its main
  method is getQtInstance, and from your words it should be disabled)

Yep, #ifdef the public methods, and do not compile the classes of the
bridge.

I've submitted https://bugs.webkit.org/show_bug.cgi?id=52469
But Simon does not like this idea.
Or have I misunderstood something?

Simon just told me that QtScript is gonna be a hard dependancy in the future, not just needed for the APIs as I thought.

So it does not make sense to enable such build options for WebKit.

I will try to get Simon to look at his emails so he can comment on this :)

cheers,
Benjamin
_______________________________________________
webkit-qt mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt

Reply via email to