On Feb 12, 2016, at 9:32 AM, Konstantin Tokarev <[email protected]> wrote:
> 
>  It would be great if someone tried to compile the code on OS X (10.10 or 
> 10.11 is required) and report encountered issues.
> 

I had to make 2 changes to build on OS X 10.11. With these changes, it builds 
and the MiniBrowser works.

1. I re-removed setCachedImage from Source/WebCore/html/HTMLImageElement.h.

2. I added a placeholder for ContextMenuItemTagOpenLinkInThisWindow in 
WebHTMLView.mm:

diff --git a/Source/WebKit/mac/WebView/WebHTMLView.mm 
b/Source/WebKit/mac/WebView/WebHTMLView.mm
index 028567f..6f24eda 100644
--- a/Source/WebKit/mac/WebView/WebHTMLView.mm
+++ b/Source/WebKit/mac/WebView/WebHTMLView.mm
@@ -529,6 +529,8 @@ static Optional<NSInteger> toTag(ContextMenuAction action)
         return WebMenuItemTagMediaMute;
     case ContextMenuItemTagDictationAlternative:
         return WebMenuItemTagDictationAlternative;
+    case ContextMenuItemTagOpenLinkInThisWindow:
+        return Nullopt;                // FIXME: This was added to QTWebKit
     case ContextMenuItemTagToggleVideoFullscreen:
         return WebMenuItemTagToggleVideoFullscreen;
     case ContextMenuItemTagShareMenu:

I can do a Pull Request if you prefer.

-Marc

_______________________________________________
webkit-qt mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-qt

Reply via email to