15.02.2016, 21:20, "mepard" <[email protected]>: > On Feb 12, 2016, at 9:32 AM, Konstantin Tokarev <[email protected]> wrote: >> It would be great if someone tried to compile the code on OS X (10.10 or >> 10.11 is required) and report encountered issues. > > I had to make 2 changes to build on OS X 10.11. With these changes, it builds > and the MiniBrowser works. > > 1. I re-removed setCachedImage from Source/WebCore/html/HTMLImageElement.h. > > 2. I added a placeholder for ContextMenuItemTagOpenLinkInThisWindow in > WebHTMLView.mm: > > diff --git a/Source/WebKit/mac/WebView/WebHTMLView.mm > b/Source/WebKit/mac/WebView/WebHTMLView.mm > index 028567f..6f24eda 100644 > --- a/Source/WebKit/mac/WebView/WebHTMLView.mm > +++ b/Source/WebKit/mac/WebView/WebHTMLView.mm > @@ -529,6 +529,8 @@ static Optional<NSInteger> toTag(ContextMenuAction action) > return WebMenuItemTagMediaMute; > case ContextMenuItemTagDictationAlternative: > return WebMenuItemTagDictationAlternative; > + case ContextMenuItemTagOpenLinkInThisWindow: > + return Nullopt; // FIXME: This was added to QTWebKit > case ContextMenuItemTagToggleVideoFullscreen: > return WebMenuItemTagToggleVideoFullscreen; > case ContextMenuItemTagShareMenu: > > I can do a Pull Request if you prefer.
No, Mac code should compile without modifications, I'll add #if for ContextMenuItemTagOpenLinkInThisWindow and setCachedImage. However, what I really wanted you to do was to build Qt port, and you've just built Mac port instead :) Building Qt port requires --qt argument to be passed to build-webkit script. See [1] for more details, it says "Linux" but some parts apply to OS X as well. You'll need to install cmake if you don't have it. build-webkit uses environment variable WEBKIT_OUTPUTDIR to choose build dir, so you can e.g. have Mac and Qt ports built from the same tree in parallel directories. Thanks! [1] https://github.com/annulen/webkit/wiki/Building-QtWebKit-on-Linux -- Regards, Konstantin _______________________________________________ webkit-qt mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-qt
