Jan Rychter <[email protected]> writes: > Could we please agree that all render-menu arguments (except for the car > in option cells) use tokens, not names? Is this a problem for anyone?
I made selected-pane be compared with target, instead of with the humanized name. That's enough for my needs right now. Pull request has been submitted. I did not touch disabled-pane-names: I remember making it behave similarly once, and then the patch got dropped or reverted. I do not want to force things on people. I believe it should be reworked again and become disabled-panes instead of disabled-pane-names, but I don't want to do it again. I also think the fact that render-menu receives so many conflicting changes is a sign that it is trying to do too much and be all things to everyone. Someone worked in a change that enables targets to be closures (actions) -- how that is supposed to work with a menu where only one item is selected, I have no idea, but it certainly won't work with my change above. I would suggest that render-menu be split and/or refactored. --J. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "weblocks" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/weblocks?hl=en -~----------~----~----~----~------~----~------~--~---
